Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix actions at ubuntu-22.04 #2016

Merged
merged 2 commits into from
Dec 17, 2024
Merged

Fix actions at ubuntu-22.04 #2016

merged 2 commits into from
Dec 17, 2024

Conversation

lauramurgatroyd
Copy link
Member

@lauramurgatroyd lauramurgatroyd commented Dec 17, 2024

Description

CI is currently failing on github because there is no module named cil https://github.com/TomographicImaging/CIL/actions/runs/12349560947/job/34461234403

Last time the actions passed was when they were running on Ubuntu 22.04.5. ubuntu-latest recently updated which version its using to Ubuntu 24.04.1 and this is when our actions started failing

actions/runner-images#10636

If you see any issues with your workflows during transition period:
Switch back to Ubuntu 22 by changing workflow YAML to use runs-on: ubuntu-22.04 We support two latest LTS Ubuntu versions, so Ubuntu 22 will still be maintained for the next 2 years.
File an issue in this repository

Example Usage

Changes

Fixed actions at ubuntu-22.04

Testing you performed

Please add any demo scripts to https://github.com/TomographicImaging/CIL-Demos/tree/main/misc

Related issues/links

Checklist

  • I have performed a self-review of my code
  • I have added docstrings in line with the guidance in the developer guide
  • I have updated the relevant documentation
  • I have implemented unit tests that cover any new or modified functionality
  • CHANGELOG.md has been updated with any functionality change
  • Request review from all relevant developers
  • Change pull request label to 'Waiting for review'

Contribution Notes

Please read and adhere to the developer guide and local patterns and conventions.

  • The content of this Pull Request (the Contribution) is intentionally submitted for inclusion in CIL (the Work) under the terms and conditions of the Apache-2.0 License
  • I confirm that the contribution does not violate any intellectual property rights of third parties

Signed-off-by: Laura Murgatroyd <[email protected]>
Signed-off-by: Laura Murgatroyd <[email protected]>
@lauramurgatroyd lauramurgatroyd changed the title Fix actions at ubuntu 22 Fix actions at ubuntu-22.04 Dec 17, 2024
@lauramurgatroyd
Copy link
Member Author

If we merge this I will open an issue for us to figure out how to get it working with ubuntu-latest

@lauramurgatroyd lauramurgatroyd marked this pull request as ready for review December 17, 2024 10:21
Copy link
Member

@MargaretDuff MargaretDuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Laura

Copy link
Contributor

@paskino paskino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's open a new issue about updating to ubuntu-latest

@lauramurgatroyd lauramurgatroyd merged commit b4d178a into master Dec 17, 2024
10 checks passed
@lauramurgatroyd lauramurgatroyd deleted the ubuntu22 branch December 17, 2024 10:43
@lauramurgatroyd
Copy link
Member Author

#2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants