allow worklet-based effects to be used with native contexts #1131
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for the following bug which occurs when trying to instantiate any effect node that uses an AudioWorklet (BitCrusher, JCReverb, etc.) if using Tone with a native context (non-Standardized Audio Context):
If there's any better way than this to check if a context is from Standardized Audio Context or not, let me know!
This is using
Now usingcontext.constructor.name.includes("AudioContext")
which catches native online & offline contexts consistently AFAICT, whereas with those created by Standardized Audio Contextcontext.constructor.name
is always an empty string.context instanceof window.BaseAudioContext
per @chrisguttandin's suggestion.