Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: refactor media name parsing #124

Merged
merged 1 commit into from
Jan 27, 2025
Merged

feat: refactor media name parsing #124

merged 1 commit into from
Jan 27, 2025

Conversation

dyphire
Copy link
Collaborator

@dyphire dyphire commented Jan 27, 2025

基于 #123

重构媒体名称解析的实现,代码取自我另一个脚本:https://github.com/dyphire/trakt-scrobble/blob/main/guess.lua

@dyphire dyphire requested a review from Tony15246 January 27, 2025 10:56
@Tony15246
Copy link
Owner

我刚刚还想抱怨github的compare功能怎么回事,主分支都合并了,diff怎么还是显示了上个pr的更改。

大佬你是强推了什么,让diff正常显示的?

@dyphire
Copy link
Collaborator Author

dyphire commented Jan 27, 2025

我刚刚还想抱怨github的compare功能怎么回事,主分支都合并了,diff怎么还是显示了上个pr的更改。

我记得以前不这样

大佬你是强推了什么,让diff正常显示的?

本地重基了再强推的

Copy link
Owner

@Tony15246 Tony15246 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Tony15246 Tony15246 merged commit 0309468 into Tony15246:main Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants