feat: add danmaku support for bilibli video playback #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dyphire
force-pushed
the
bilibili
branch
7 times, most recently
from
719193f to
9f094d4
Compare
|
大佬觉得这个fallback有必要添加吗？或者我可以先pr，后面再优化和添加fallback。 |
我在调试 fallback，本地似乎出了点问题 |
OK |
dyphire
force-pushed
the
bilibili
branch
2 times, most recently
from
235f17d to
394f7c4
Compare
|
应该可以了 |
Tony15246
approved these changes
Nov 12, 2024
| end | ||
|
|
||
| if cid == nil then | ||
| cid = mp.get_opt('cid') |
There was a problem hiding this comment.
这里我觉得还可以再加一个fallback，参考下面这个实现。不过这个实现的正则我觉得写的有点不太好，我个人觉得用这个正则匹配更好一点bilivideo%.c[nom]+.*/(%d+)-%d+-%d+%.%.*%?
There was a problem hiding this comment.
个人觉得可以加一段下面这样的，作为mp.get_opt('cid')拿不到时候的fallback
local pat = "bilivideo%.c[nom]+.*/(%d+)-%d+-%d+%.%.*%?"
local path = mp.get_property("path")
if path:find(pat) then
cid = path:match(pat)
end
end
dyphire
pushed a commit
to dyphire/uosc_danmaku
that referenced
this pull request
Jan 25, 2025
feat: add danmaku support for bilibli video playback
dyphire
pushed a commit
to dyphire/uosc_danmaku
that referenced
this pull request
Jan 25, 2025
feat: add danmaku support for bilibli video playback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
另见 #57