Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Array and string offset access syntax with curly braces is no longer supported #45

Closed
gixxy22 opened this issue Sep 3, 2021 · 2 comments · Fixed by #52
Closed

Array and string offset access syntax with curly braces is no longer supported #45

gixxy22 opened this issue Sep 3, 2021 · 2 comments · Fixed by #52
Assignees
@michaelrog
Labels
bug good first issue PR welcome!
Milestone
PHP 8 Compatibility

Comments

@gixxy22
Copy link

gixxy22 commented Sep 3, 2021

in /vendor/topshelfcraft/wordsmith/src/libs/FullNameParser.phpat line 476

return ((mb_strlen($word) == 1) || (mb_strlen($word) == 2 && $word{1} == "."));

curly braces are no longer supported in PHP8
@gixxy22
Copy link
Author

gixxy22 commented Sep 3, 2021

theres a few other lines where curly braces are used in that file too.

@michaelrog
Copy link
Member

Thanks for bringing this up. Will get an 8.0-friendly update out.

@michaelrog michaelrog self-assigned this Sep 4, 2021
@michaelrog michaelrog added this to the PHP 8 Compatibility milestone Sep 4, 2021
@rob-c-baker rob-c-baker mentioned this issue Mar 24, 2022
Closed
@Saboteur777 Saboteur777 mentioned this issue Jun 2, 2022
Merged
michaelrog added a commit that referenced this issue Jun 5, 2022
@michaelrog
Release 4.0.1. (Closes #45.)
c2e5176
michaelrog added a commit that referenced this issue Jun 5, 2022
@michaelrog
Update string access syntax for PHP 8 support. (Fixes #45 for 3.x.)
320dc4f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@michaelrog michaelrog

Labels
bug good first issue PR welcome!
Projects
None yet
Milestone
PHP 8 Compatibility
Development

Successfully merging a pull request may close this issue.

Change curly braces to brackets
2 participants
@michaelrog @gixxy22