Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SQL Server MDS: Use SqlCommand.EnableOptimizedParameterBinding #439

Closed
Grauenwolf opened this issue Mar 8, 2022 · 0 comments
Closed

SQL Server MDS: Use SqlCommand.EnableOptimizedParameterBinding #439

Grauenwolf opened this issue Mar 8, 2022 · 0 comments
Labels
SQL Server
Milestone
Tortuga Chain 4.1

Comments

@Grauenwolf
Copy link
Collaborator

dotnet/SqlClient#1041
https://docs.microsoft.com/en-us/dotnet/api/microsoft.data.sqlclient.sqlcommand.enableoptimizedparameterbinding?view=sqlclient-dotnet-standard-4.1

We probably want to default to turning this on unless we detect an Output or InputOutput parameter.
In real world terms it doesn't have an effect unless there are at least 24 parameters. But we can hit that with particularly large rows.
@Grauenwolf Grauenwolf added this to the Tortuga Chain 4.1 milestone Mar 8, 2022
Grauenwolf added a commit that referenced this issue Jun 22, 2022
@Grauenwolf
SQL Server MDS: Use SqlCommand.EnableOptimizedParameterBinding #439
e47b080 
Added test case for command timeout.
Created `ExecutionToken.PopulateCommand` method.
@Grauenwolf Grauenwolf mentioned this issue Jun 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
SQL Server
Projects
None yet
Milestone
Tortuga Chain 4.1
Development

No branches or pull requests
1 participant
@Grauenwolf