Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CICD isn't working properly #238

Closed
acmlira opened this issue Dec 17, 2020 · 1 comment · Fixed by #239 or #242
Closed

CICD isn't working properly #238

acmlira opened this issue Dec 17, 2020 · 1 comment · Fixed by #239 or #242
Assignees
Labels
enhancement Feature improvements feature New feature or request
Milestone

Comments

@acmlira
Copy link
Contributor

acmlira commented Dec 17, 2020

About the latest CI changes: "knowing if changes don't break and continuous delivery" has been replaced only by "continuous delivery". Some use cases cause problems:

  • Commit checking only works for the newest commit;
  • When applying changes to any file that is not compiled the workflows are being activated;
  • Build for arm32v7 already takes around 12 minutes and the "Build SDK and Zip" ¹ step takes more 12 minutes, but not every build will be turned into a release;
  • The build workflow is only triggered after the commit enters the master but it is a requirement for integration (cyclical dependency);

My diagnosis is that the tasks are closely linked. My feature requests are:

  • Add skip-ci flag;
  • About "Build SDK and Zip" ¹ put the dirty build job into the release workflow;
  • Fix the cyclical dependency.

¹ The second stage of the main.yml workflow.

@acmlira acmlira added enhancement Feature improvements feature New feature or request labels Dec 17, 2020
@acmlira acmlira changed the title CICD is just an incomplete CD CICD isn't working properly Dec 17, 2020
acmlira added a commit that referenced this issue Dec 17, 2020
Fix the issue described in #238

Signed-off: @acmlira
@acmlira acmlira self-assigned this Dec 17, 2020
acmlira added a commit that referenced this issue Dec 17, 2020
Fix the issue described in #238

Signed-off: @acmlira
acmlira added a commit that referenced this issue Dec 18, 2020
Fix the issue described in #238. Workflow overlooked in previous commit.

Signed-off: @acmlira
acmlira added a commit that referenced this issue Dec 18, 2020
Fix the issue described in #238. Workflow overlooked in previous commit.

Signed-off: @acmlira
acmlira added a commit that referenced this issue Dec 18, 2020
Fix the issue described in #238. Workflow overlooked in previous commit.

Signed-off: @acmlira
@acmlira
Copy link
Contributor Author

acmlira commented Dec 22, 2020

skip-ci it is not possible at the moment and about "Build SDK and Zip" It will give additional work that need to be solved with #248

@acmlira acmlira closed this as completed Dec 22, 2020
@acmlira acmlira added this to the 7.0 milestone Dec 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature improvements feature New feature or request
Projects
None yet
1 participant