feat: Namespace key in map as Str
#342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| } | ||
|
|
||
| /// Closes all engine.io connections and all clients | ||
| #[cfg_attr(feature = "tracing", tracing::instrument(skip(self)))] | ||
| pub(crate) async fn close(&self) { | ||
| #[cfg(feature = "tracing")] | ||
| tracing::debug!("closing all namespaces"); | ||
| let ns = { std::mem::take(&mut *self.ns.write().unwrap()) }; | ||
| let ns = { std::mem::take(&mut *self.nsps.write().unwrap()) }; |
Check warning
Code scanning / clippy
mutable key type Warning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Most of the Namespace paths are now
Str. It allows to avoid lifetime issue and reduce allocations. To match the use ofStrin the codebase we can also switch from aHashmap<Cow<'static, str>, Namespace>to aHashmap<Str, Namespace>. Thanks to that there is not only no copying when using'static str(this was already the case) but also when using ownedString. For example with dynamic namespaces or when the user provide owned strings.Fixes also a minor memory leak where namespaces created from dynamic namespaces were keeping a ref to the namespace path in the connect packet. Thus never freeing the packet.