Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump tokio tungstenite to 0.26 #428

Merged
merged 6 commits into from
Jan 13, 2025
Merged

Bump tokio tungstenite to 0.26 #428

merged 6 commits into from
Jan 13, 2025

Conversation

Totodore
Copy link
Owner

@Totodore Totodore commented Jan 12, 2025

  • Use new tokio-tungstenite Message API with Bytes rather than owned Vec. Thanks to that we have much less allocations when reading/writing to websockets.
  • Switch from TryFrom<Packet> for String to From<Packet> for String because there is no errors when serializing a packet to a string.

@Totodore Totodore force-pushed the bump-tokio-tungstenite branch from 264f36e to d8e13f4 Compare January 12, 2025 18:57
@Totodore Totodore force-pushed the bump-tokio-tungstenite branch from d8e13f4 to e37edb6 Compare January 12, 2025 19:06
crates/socketioxide/tests/fixture.rs Fixed Show fixed Hide fixed
crates/socketioxide/tests/fixture.rs Fixed Show fixed Hide fixed
crates/socketioxide/tests/fixture.rs Fixed Show fixed Hide fixed
@Totodore Totodore force-pushed the bump-tokio-tungstenite branch from 34661ee to 9118637 Compare January 13, 2025 13:34
@Totodore Totodore changed the title Bump tokio tungstenite Bump tokio tungstenite to 0.26 Jan 13, 2025
@Totodore Totodore enabled auto-merge (squash) January 13, 2025 13:42
@Totodore Totodore merged commit fe09c45 into main Jan 13, 2025
14 of 16 checks passed
@Totodore Totodore deleted the bump-tokio-tungstenite branch January 17, 2025 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant