Skip to content

Commit

Permalink
Revert "fragment cypress test fix (#7547)"
Browse files Browse the repository at this point in the history
This reverts commit 57f13ef.
  • Loading branch information
Dzuming committed Feb 12, 2025
1 parent 43af50e commit bb6aa6f
Showing 1 changed file with 14 additions and 39 deletions.
53 changes: 14 additions & 39 deletions designer/client/cypress/e2e/fragment.cy.ts
Original file line number Diff line number Diff line change
Expand Up @@ -369,92 +369,70 @@ describe("Fragment", () => {
cy.deleteAllTestProcesses({ filter: seed2 });
});

it("should display dead-ended fragment correct", () => {
it.skip("should display dead-ended fragment correct", () => {
const fragmentName = "fragmentOutput";
const deadEndFragmentName = "fragmentDeadEnd";
cy.createTestFragment(fragmentName, "fragment").as("fragmentName");
cy.visitNewProcess(seed, "testProcess").as("scenarioName");
cy.createTestFragment(deadEndFragmentName, "deadEndFragment");

cy.layoutScenario();
cy.get("#nk-graph-main").should("be.visible");

cy.contains("fragments").should("exist").scrollIntoView();
cy.getNode("enricher").should("be.visible").as("enricher");

cy.getNode("enricher").as("enricher");
cy.contains(`${fragmentName}-test`)
.last()
.should("be.visible")
.and("not.be.disabled")
.drag("@enricher", {
target: {
x: 250,
y: -20,
},
force: true,
});

cy.layoutScenario();
cy.get("#nk-graph-main").should("be.visible");

cy.contains(/^save\*$/i)
.should("be.enabled")
.click();
cy.contains(/^ok$/i).should("be.enabled").click();
cy.contains(/^save\*$/i).click();
cy.contains(/^ok$/i).click();

cy.get<string>("@fragmentName").then((name) => cy.visitProcess(name));
cy.get("#nk-graph-main").should("be.visible");

cy.contains("sinks").should("exist").scrollIntoView();
cy.getNode("output").should("be.visible").as("output");

cy.get("@output").should("be.visible").and("not.be.disabled").click();
cy.getNode("output").as("output");

// There is a race condition
// and it can be a situation that dead-end node is dropped before the scenario is visible.
// To be sure that element is visible, let's click on it first
cy.get("@output").click();
cy.get("@output").then((node) => {
const { left, top } = node.position();

cy.contains("dead-end")
.first()
.should("be.visible")
.and("not.be.disabled")
.drag("@output", {
target: {
x: 0,
y: node.height() / 2,
},
force: true,
});

cy.wait(100); // Small delay to ensure drag completed
// make sure dropped on edge
cy.dragNode("dead-end", {
x: left,
y: top + node.height() / 2,
});
});

cy.get("@output").should("be.visible").click({ force: true }).type("{backspace}");
cy.contains(/^save\*$/i)
.should("be.enabled")
.click();
cy.contains(/^ok$/i).should("be.enabled").click();
cy.get("@output").click({ force: true }).type("{backspace}");
cy.contains(/^save\*$/i).click();
cy.contains(/^ok$/i).click();
cy.contains(/^save$/i).should("be.disabled");

cy.viewport(2000, 800);
cy.get<string>("@scenarioName").then((name) => cy.visitProcess(name));
cy.get("#nk-graph-main").should("be.visible");
cy.layoutScenario();

cy.getNode("sendSms").should("be.visible").as("sendSms");
cy.getNode("sendSms").as("sendSms");
cy.contains("fragments").should("exist").scrollIntoView();

cy.contains(`${deadEndFragmentName}-test`)
.last()
.should("be.visible")
.and("not.be.disabled")
.drag("@sendSms", {
target: {
x: 240,
Expand All @@ -465,13 +443,10 @@ describe("Fragment", () => {

cy.viewport("macbook-16");
cy.layoutScenario();
cy.get("#nk-graph-main").should("be.visible");

cy.get('[joint-selector="layers"]')
.should("be.visible")
.matchImage({
maxDiffThreshold: 0.015,
screenshotConfig: { padding: 16 },
});
cy.get('[joint-selector="layers"]').matchImage({
maxDiffThreshold: 0.015,
screenshotConfig: { padding: 16 },
});
});
});

0 comments on commit bb6aa6f

Please sign in to comment.