[NU-1806] Cleanup for getActionParameters (#7564)

TouK · Feb 17, 2025 · e7e62b0 · e7e62b0
1 parent 8f695ea
commit e7e62b0
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 6 deletions.
diff --git a/designer/client/src/components/modals/DeployWithParametersDialog.tsx b/designer/client/src/components/modals/DeployWithParametersDialog.tsx
@@ -3,7 +3,7 @@ import { WindowButtonProps, WindowContentProps } from "@touk/window-manager";
 import React, { useCallback, useEffect, useMemo, useState } from "react";
 import { useTranslation } from "react-i18next";
 import { useSelector } from "react-redux";
-import { getProcessName, getProcessVersionId, getScenarioGraph } from "../../reducers/selectors/graph";
+import { getProcessName, getProcessVersionId } from "../../reducers/selectors/graph";
 import { getFeatureSettings } from "../../reducers/selectors/settings";
 import { PromptContent, WindowKind } from "../../windowManager";
 import CommentInput from "../comment/CommentInput";
@@ -38,15 +38,14 @@ export function DeployWithParametersDialog(props: WindowContentProps<WindowKind,
     } = props.data;
     const processName = useSelector(getProcessName);
     const processVersionId = useSelector(getProcessVersionId);
-    const scenarioGraph = useSelector(getScenarioGraph);
     const { showBoundary } = useErrorBoundary();
     const [isLoading, setIsLoading] = useState<boolean>(false);
     const [parametersDefinition, setParametersDefinition] = useState([]);
     const [parametersValues, setParametersValues] = useState({});
 
     const getActionParameters = useCallback(async () => {
         setIsLoading(true);
-        await HttpService.getActionParameters(processName, scenarioGraph)
+        await HttpService.getActionParameters(processName)
             .then((response) => {
                 const definition = response.data.actionNameToParameters["DEPLOY"] || ([] as ActionNodeParameters[]);
                 const initialValues = initialNodesData(definition);
@@ -59,11 +58,11 @@ export function DeployWithParametersDialog(props: WindowContentProps<WindowKind,
             .finally(() => {
                 setIsLoading(false);
             });
-    }, [processName, scenarioGraph, showBoundary]);
+    }, [processName, showBoundary]);
 
     useEffect(() => {
         getActionParameters();
-    }, [processName, scenarioGraph, getActionParameters]);
+    }, [processName, getActionParameters]);
 
     const [comment, setComment] = useState("");
     const [validationError, setValidationError] = useState("");

diff --git a/designer/client/src/http/HttpService.ts b/designer/client/src/http/HttpService.ts
@@ -704,7 +704,7 @@ class HttpService {
         return promise;
     }
 
-    getActionParameters(processName: string, scenarioGraph: ScenarioGraph) {
+    getActionParameters(processName: string) {
         const promise = api.get(`/actionInfo/${encodeURIComponent(processName)}/parameters`);
         promise.catch((error) =>
             this.#addError(