Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(googlesheets2): first pass at passing token #198

Merged
merged 1 commit into from
Sep 2, 2020
Merged

feat(googlesheets2): first pass at passing token #198

merged 1 commit into from
Sep 2, 2020

Conversation

testinnplayin
Copy link
Contributor

@testinnplayin testinnplayin commented Aug 26, 2020 •
edited
Loading

Change Summary

Passing an access_token and refresh token (if applicable) to the connector.

Associated PR

https://github.com/ToucanToco/laputa/pull/3574

Checklist

  • Unit tests for the changes exist
  • Tests pass on CI and coverage remains at 100%
  • Documentation reflects the changes where applicable

@testinnplayin testinnplayin self-assigned this Aug 26, 2020
@testinnplayin
Copy link
Contributor Author

(3) ETQC, je peux passer ces tokens pour faire des requêtes au connecteur Google Sheets

@testinnplayin
Copy link
Contributor Author

(2) Au moment de passer la requête vers le connecteur, laputa cherche les secrets dans la BDD collection des secrets et les passe sous forme de dict au connecteur

@testinnplayin
Copy link
Contributor Author

(1) Le connecteur Google Sheets utilise le secret pour autoriser la connexion

@testinnplayin testinnplayin force-pushed the f/pass-token-to-google-sheets branch 3 times, most recently from 2bfb1b6 to a6fcfab Compare August 28, 2020 09:30
@codecov
Copy link

codecov bot commented Aug 28, 2020 •
edited
Loading

Codecov Report

Merging #198 into f/bearer-api-replacement will decrease coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@                     Coverage Diff                      @@
##           f/bearer-api-replacement     #198      +/-   ##
============================================================
- Coverage                     97.66%   97.60%   -0.06%     
============================================================
  Files                            42       43       +1     
  Lines                          2137     2131       -6     
============================================================
- Hits                           2087     2080       -7     
- Misses                           50       51       +1
Impacted Files Coverage Δ
...ctors/google_sheets_2/google_sheets_2_connector.py 100.00% <100.00%> (ø)
toucan_connectors/toucan_connector.py 98.52% <100.00%> (-0.07%) ⬇️
toucan_connectors/condition_translator.py 98.87% <0.00%> (-1.13%) ⬇️
toucan_connectors/mysql/mysql_connector.py 92.64% <0.00%> (-0.28%) ⬇️
toucan_connectors/google_credentials.py 100.00% <0.00%> (ø)
toucan_connectors/micro_strategy/data.py 100.00% <0.00%> (ø)
toucan_connectors/micro_strategy/client.py 100.00% <0.00%> (ø)
toucan_connectors/mongo/mongo_connector.py 100.00% <0.00%> (ø)
toucan_connectors/snowflake/snowflake_connector.py 100.00% <0.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4203b86...ead3a22. Read the comment docs.

@testinnplayin testinnplayin force-pushed the f/pass-token-to-google-sheets branch from 26f7f5d to 9ad454e Compare August 28, 2020 12:48
@testinnplayin testinnplayin force-pushed the f/bearer-api-replacement branch from 8ba1c5d to 86e0f3f Compare August 28, 2020 12:50
@testinnplayin testinnplayin removed the wip label Aug 28, 2020
PrettyWood
PrettyWood requested changes Aug 28, 2020
View reviewed changes
toucan_connectors/toucan_connector.py Outdated Show resolved Hide resolved
@testinnplayin testinnplayin force-pushed the f/pass-token-to-google-sheets branch 2 times, most recently from a650e2b to bb803b8 Compare August 31, 2020 11:26
@PrettyWood
Copy link
Member

@testinnplayin Je n'ai rien effacé tu peux juste revert mon commit...je ne comprends pas le souci

@testinnplayin
Copy link
Contributor Author

C'est moi qui me suis trompée... je m'excuse !

@testinnplayin testinnplayin force-pushed the f/pass-token-to-google-sheets branch 7 times, most recently from 19bba96 to 1e600da Compare September 1, 2020 12:19
@testinnplayin testinnplayin force-pushed the f/pass-token-to-google-sheets branch from 1e600da to 63a1c30 Compare September 1, 2020 14:14
davinov
davinov approved these changes Sep 1, 2020
View reviewed changes
Copy link
Member

@davinov davinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the modifications
Having a set_secrets method is way better than passing it from one function to another ^^

PrettyWood
PrettyWood reviewed Sep 1, 2020
View reviewed changes
tests/test_connector.py Outdated Show resolved Hide resolved
@testinnplayin
feat(googlesheets2): first pass at passing token
ead3a22 
put in conditional to prevent bug

replaced specific variable to kwargs

Fixed function signature inspection

- Now works for 3.6 and 3.8
- Removed version checker function from test helpers to common

added test

added test for codecov
@testinnplayin testinnplayin force-pushed the f/pass-token-to-google-sheets branch from 63a1c30 to ead3a22 Compare September 1, 2020 16:06
@testinnplayin testinnplayin merged commit bb3ae63 into f/bearer-api-replacement Sep 2, 2020
@testinnplayin testinnplayin deleted the f/pass-token-to-google-sheets branch September 2, 2020 07:02
erenard pushed a commit that referenced this pull request Sep 2, 2020
@testinnplayin @erenard
feat(googlesheets2): first pass at passing token (#198)
355024d 
added test for codecov
testinnplayin added a commit that referenced this pull request Sep 2, 2020
@testinnplayin
feat(googlesheets2): first pass at passing token (#198)
28e0033 
added test for codecov
testinnplayin added a commit that referenced this pull request Sep 2, 2020
@testinnplayin
feat(googlesheets2): first pass at passing token (#198)
da69a6f 
added test for codecov
testinnplayin added a commit that referenced this pull request Sep 2, 2020
@testinnplayin
feat(googlesheets2): first pass at passing token (#198)
6421ba9 
added test for codecov
testinnplayin added a commit that referenced this pull request Sep 2, 2020
@testinnplayin
feat(googlesheets2): first pass at passing token (#198)
c93591b 
added test for codecov

fixed test
testinnplayin added a commit that referenced this pull request Sep 4, 2020
@testinnplayin
feat(googlesheets2): first pass at passing token (#198)
0a46162 
added test for codecov
testinnplayin added a commit that referenced this pull request Sep 4, 2020
@testinnplayin
feat(googlesheets2): first pass at passing token (#198)
da22b3b 
added test for codecov

fixed test
davinov pushed a commit that referenced this pull request Sep 4, 2020
@testinnplayin @davinov
feat(googlesheets2): first pass at passing token (#198)
4cb66ac 
added test for codecov
davinov pushed a commit that referenced this pull request Sep 4, 2020
@testinnplayin @davinov
feat(googlesheets2): first pass at passing token (#198)
8c64b88 
added test for codecov

fixed test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PrettyWood PrettyWood PrettyWood approved these changes

@davinov davinov davinov approved these changes

Assignees

@testinnplayin testinnplayin

Labels
Need Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@testinnplayin @PrettyWood @davinov