Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: Town/Nation Based Beacon Effects #7532

Closed
TylorTurner opened this issue Jul 27, 2024 · 0 comments · Fixed by #7603
Closed

Suggestion: Town/Nation Based Beacon Effects #7532

TylorTurner opened this issue Jul 27, 2024 · 0 comments · Fixed by #7603
Assignees
Milestone

Comments

@TylorTurner
Copy link

Please explain your feature request to the best of your abilities:

Allow only nations and towns to use the benefits of beacons within their towns.
Also an option to deny conquered towns that benefit as well.

LlmDl added a commit that referenced this issue Sep 16, 2024
in towns.
  - Requires Paper for this to work.
  - Closes #7532

  - New Config Option: global_town_settings.beacons_for_allies_only
    - Default: false
    - When true, a beacon placed in a town will only affect the allies
of the town. This includes residents, nation residents and allied nation
residents.
@LlmDl LlmDl self-assigned this Sep 16, 2024
@LlmDl LlmDl added this to the 0.100.5.0 milestone Sep 16, 2024
@LlmDl LlmDl closed this as completed in 4b96427 Sep 19, 2024
LlmDl added a commit that referenced this issue Sep 19, 2024
placed in towns.
    - Requires Paper to work.
    - Closes #7532.
  - New Config Option: global_town_settings.beacons_for_allies_only
    - Default: false
    - When true, a beacon placed in a town will only affect the allies
of the town. This includes residents, nation residents and allied nation
residents.
  - New Config Option:
global_town_settings.beacons.exclude_conquered_towns
    - Default: false
    - When true, conquered towns are not considered allies.
  - Add experimental option to consider conquered towns as not allies.
  - New Config Option:
global_nation_settings.are_conquered_towns_considered_allies
    - Default: true
    - While true, conquered towns will be considered a member of good
standing in the nation.
    - When set to false CombatUtil#isAlly() tests will treat conquered
towns and their nations as not allied.
    - Setting this to false could result in strange unforseen behaviour.
  - Bump org.apache.logging.log4j:log4j-core from 2.23.1 to 2.24.0.
  - Bump org.bstats:bstats-bukkit from 3.0.2 to 3.0.3.
  - Bump org.junit.jupiter:junit-jupiter from 5.10.3 to 5.11.0.
  - Bump org.junit.jupiter:junit-jupiter-api from 5.10.3 to 5.11.0.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants