Per-user config implementation, reworked and extended #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@SiteRelEnby I was trying out your update as this is a feature I am interested in. I had some issues that I attempted to fix. However, I am not that familiar with github flow, so the extra pull request may not be the right way. Apologies if I missed something #59 |
|
@crox merged into this one, thanks |
|
Thanks @SiteRelEnby & @crox - I've just tested this PR locally and this worked flawless with "global"+model overrides. |
|
Finally got around to checking this out. Haven't tried building with this yet but it looks like a nice improvement over my original work! |
SiteRelEnby
force-pushed
the
feature/user_customization
branch
from
4aa8a71 to
67ec848
Compare
|
Small update with a few script optimisations + nice-to-haves, no functional changes. |
Based on @ntoivola's work, restructured users/ directory to allow for custom model configuration, rewrote documentation, improved script flexibility around user configuration. Now have per-user configuration working with my own custom builds, and also did the base work for heavier customisation such as multiple custom configuration files per build target. An example repository for user configs is also in progress.
…don't prevent default builds from building when a user config is specified, update documentation, general refactoring
…al argument to show summary of successful builds
SiteRelEnby
force-pushed
the
feature/user_customization
branch
from
67ec848 to
c290f61
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on @ntoivola's work, restructured users/ directory to allow for custom model configuration, rewrote documentation, improved script flexibility around user configuration. Now have per-user configuration working with my own custom builds, and also did the base work for heavier customisation such as multiple custom configuration files per build target. An example repository for user configs is also in progress.