Bugfix: channel_mode for strobe->off, start on ramp #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
readableness
force-pushed
the
fix_strobe_channel_off
branch
from
7e7bc83 to
4f5c8a3
Compare
|
Updated commit to 4f5c8a3 to fix one more case - user interrupts off sequence/animation with a click to moon/on/turbo. This immediately restores the ramp I believe this now covers all aspects of {strobe -> off -> ramp} that we can pull off:
|
restore ramp channel_mode before on. Fixes ToyKeeper#64
readableness
force-pushed
the
fix_strobe_channel_off
branch
from
4f5c8a3 to
603b7be
Compare
SiteRelEnby
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix channel_mode during smooth_steps operations. Maintain channel_mode until animation complete, restore ramp channel_mode before on.
Multichannel lights reverted to ramp channel_mode prior to actual off, unpleasantly mixing channels for some users during fade to off. Additionally, the ramp channel_mode would not always be restored before turning on, animating with the wrong channel_mode, then jumping to correct channel_mode at animation completion.