-
Notifications
You must be signed in to change notification settings - Fork 131
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Installations on MacOS didn't properly work after 8ee7ab3 because MacOS doesn't like the `-rpath=x` syntax. The changed patch makes clang invocations compatible with both Linux and MacOS. Added regression testing to CI so that we don't overlook issues like this in the future. Fixes #918 Co-authored-by: Zach Birenbaum <[email protected]>
- Loading branch information
1 parent
ba7ed50
commit 6183525
Showing
7 changed files
with
274 additions
and
248 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 changes: 3 additions & 3 deletions
6
local-remote-execution/generated-cc/cc/builtin_include_directory_paths
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,11 +1,11 @@ | ||
This file is generated by cc_configure and contains builtin include directories | ||
that /nix/store/6fr9bp9drswk1azlcby44c97l9xiifbm-customClang/bin/customClang reported. This file is a dependency of every compilation action and | ||
that /nix/store/d6x389rgl2x9b6dkwxc71grbzgmkr28c-customClang/bin/customClang reported. This file is a dependency of every compilation action and | ||
changes to it will be reflected in the action cache key. When some of these | ||
paths change, Bazel will make sure to rerun the action, even though none of | ||
declared action inputs or the action commandline changes. | ||
|
||
/nix/store/vqbgiwjvjbgypsfwgpdc78asxvx13lsm-clang-wrapper-18.1.5/resource-root/include | ||
/nix/store/5ark5p94q2nwni9rkq9zqnfsyfv9y50w-clang-wrapper-18.1.5/resource-root/include | ||
/nix/store/s3pvsv4as7mc8i2nwnk2hnsyi2qdj4bq-glibc-2.39-31-dev/include | ||
/nix/store/vqbgiwjvjbgypsfwgpdc78asxvx13lsm-clang-wrapper-18.1.5/resource-root/share | ||
/nix/store/5ark5p94q2nwni9rkq9zqnfsyfv9y50w-clang-wrapper-18.1.5/resource-root/share | ||
/nix/store/csml9b5w7z51yc7hxgd2ax4m6vj36iyq-libcxx-18.1.5-dev/include/c++/v1 | ||
/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.