Test nix builds #920
Test nix builds #920
Conversation
aaronmondal
force-pushed
the
fix-nix-macos
branch
from
8b18ce6 to
7a4f5ea
Compare
There was a problem hiding this comment.
Reviewable status: 0 of 2 LGTMs obtained, and pending CI: Analyze (javascript-typescript), Analyze (python), Bazel Dev / ubuntu-22.04, Cargo Dev / macos-13, Cargo Dev / ubuntu-22.04, Installation / macos-13, Installation / macos-14, Installation / ubuntu-22.04, Local / ubuntu-22.04, Publish image, Publish nativelink-worker-lre-cc, Remote / large-ubuntu-22.04, asan / ubuntu-22.04, docker-compose-compiles-nativelink (20.04), docker-compose-compiles-nativelink (22.04), integration-tests (20.04), integration-tests (22.04), macos-13, pre-commit-checks, ubuntu-20.04 / stable, ubuntu-22.04, ubuntu-22.04 / stable, windows-2022 / stable (waiting on @allada and @zbirenbaum)
Installations on MacOS didn't properly work after 8ee7ab3 because MacOS doesn't like the `-rpath=x` syntax. The changed patch makes clang invocations compatible with both Linux and MacOS. Added regression testing to CI so that we don't overlook issues like this in the future. Fixes TraceMachina#918 Co-authored-by: Zach Birenbaum <[email protected]>
aaronmondal
force-pushed
the
fix-nix-macos
branch
from
7a4f5ea to
6183525
Compare
There was a problem hiding this comment.
Reviewed 7 of 7 files at r1, all commit messages.
Reviewable status: 0 of 2 LGTMs obtained (waiting on @allada and @zbirenbaum)
Installations on MacOS didn't properly work after 8ee7ab3 because MacOS doesn't like the
-rpath=xsyntax.The changed patch makes clang invocations compatible with both Linux and MacOS. Added regression testing to CI so that we don't overlook issues like this in the future.
This change is