Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Store API should support anything that can be converted into a str #934

Closed
allada opened this issue May 27, 2024 · 0 comments · Fixed by #964
Closed

Store API should support anything that can be converted into a str #934

allada opened this issue May 27, 2024 · 0 comments · Fixed by #964

Comments

@allada
Copy link
Member

allada commented May 27, 2024

Currently the store api requires all keys to be DigestInfo, but in reality it should accept something that turns into a str.
allada added a commit to allada/nativelink-fork that referenced this issue May 27, 2024
@allada
Refactor Store Api into client side and driver side
621b91f 
Refactors the Store api into the driver (backend) implementation
and a client Store/StoreLike api. Store & StoreLike have their
sizes known at compile-time. This enables us to add templates
to the client-side to make it easier to work with, for example,
we no longer need to Pin the store and we'll be able to add
things like `digest: impl Into<DigestInfo>` to make the callers
life much easier.

towards: TraceMachina#934
@allada allada mentioned this issue May 27, 2024
Merged
allada added a commit to allada/nativelink-fork that referenced this issue May 27, 2024
@allada
Refactor Store Api into client side and driver side
c089537 
Refactors the Store api into the driver (backend) implementation
and a client Store/StoreLike api. Store & StoreLike have their
sizes known at compile-time. This enables us to add templates
to the client-side to make it easier to work with, for example,
we no longer need to Pin the store and we'll be able to add
things like `digest: impl Into<DigestInfo>` to make the callers
life much easier.

towards: TraceMachina#934
allada added a commit to allada/nativelink-fork that referenced this issue May 28, 2024
@allada
Refactor Store Api into client side and driver side
bf880cf 
Refactors the Store api into the driver (backend) implementation
and a client Store/StoreLike api. Store & StoreLike have their
sizes known at compile-time. This enables us to add templates
to the client-side to make it easier to work with, for example,
we no longer need to Pin the store and we'll be able to add
things like `digest: impl Into<DigestInfo>` to make the callers
life much easier.

towards: TraceMachina#934
allada added a commit to allada/nativelink-fork that referenced this issue May 28, 2024
@allada
Refactor Store Api into client side and driver side
f3c1657 
Refactors the Store api into the driver (backend) implementation
and a client Store/StoreLike api. Store & StoreLike have their
sizes known at compile-time. This enables us to add templates
to the client-side to make it easier to work with, for example,
we no longer need to Pin the store and we'll be able to add
things like `digest: impl Into<DigestInfo>` to make the callers
life much easier.

towards: TraceMachina#934
allada added a commit to allada/nativelink-fork that referenced this issue May 28, 2024
@allada
Refactor Store Api into client side and driver side
1883eba 
Refactors the Store api into the driver (backend) implementation
and a client Store/StoreLike api. Store & StoreLike have their
sizes known at compile-time. This enables us to add templates
to the client-side to make it easier to work with, for example,
we no longer need to Pin the store and we'll be able to add
things like `digest: impl Into<DigestInfo>` to make the callers
life much easier.

towards: TraceMachina#934
allada added a commit to allada/nativelink-fork that referenced this issue May 28, 2024
@allada
Refactor Store Api into client side and driver side
26ed4fd 
Refactors the Store api into the driver (backend) implementation
and a client Store/StoreLike api. Store & StoreLike have their
sizes known at compile-time. This enables us to add templates
to the client-side to make it easier to work with, for example,
we no longer need to Pin the store and we'll be able to add
things like `digest: impl Into<DigestInfo>` to make the callers
life much easier.

towards: TraceMachina#934
allada added a commit to allada/nativelink-fork that referenced this issue May 28, 2024
@allada
Refactor Store Api into client side and driver side
72d3bd7 
Refactors the Store api into the driver (backend) implementation
and a client Store/StoreLike api. Store & StoreLike have their
sizes known at compile-time. This enables us to add templates
to the client-side to make it easier to work with, for example,
we no longer need to Pin the store and we'll be able to add
things like `digest: impl Into<DigestInfo>` to make the callers
life much easier.

towards: TraceMachina#934
allada added a commit to allada/nativelink-fork that referenced this issue May 28, 2024
@allada
Refactor Store Api into client side and driver side
fef7e6d 
Refactors the Store api into the driver (backend) implementation
and a client Store/StoreLike api. Store & StoreLike have their
sizes known at compile-time. This enables us to add templates
to the client-side to make it easier to work with, for example,
we no longer need to Pin the store and we'll be able to add
things like `digest: impl Into<DigestInfo>` to make the callers
life much easier.

towards: TraceMachina#934
allada added a commit to allada/nativelink-fork that referenced this issue May 28, 2024
@allada
Refactor Store Api into client side and driver side
6d6630e 
Refactors the Store api into the driver (backend) implementation
and a client Store/StoreLike api. Store & StoreLike have their
sizes known at compile-time. This enables us to add templates
to the client-side to make it easier to work with, for example,
we no longer need to Pin the store and we'll be able to add
things like `digest: impl Into<DigestInfo>` to make the callers
life much easier.

towards: TraceMachina#934
allada added a commit to allada/nativelink-fork that referenced this issue Jun 4, 2024
@allada
Refactor Store API to use StoreKey
119e6f8 
This enables us to use arbitraty strings when using the Store API.

closes TraceMachina#934
allada added a commit to allada/nativelink-fork that referenced this issue Jun 4, 2024
@allada
Refactor Store API to use StoreKey
5763385 
This enables us to use arbitraty strings when using the Store API.

closes TraceMachina#934
allada added a commit to allada/nativelink-fork that referenced this issue Jun 4, 2024
@allada
Refactor Store API to use StoreKey
4dc8464 
This enables us to use arbitrary strings when using the Store API.

closes TraceMachina#934
@allada allada mentioned this issue Jun 4, 2024
Merged
allada added a commit to allada/nativelink-fork that referenced this issue Jun 4, 2024
@allada
Refactor Store API to use StoreKey
46daffd 
This enables us to use arbitrary strings when using the Store API.

closes TraceMachina#934
allada added a commit to allada/nativelink-fork that referenced this issue Jun 4, 2024
@allada
Refactor Store Api into client side and driver side
f5111b0 
Refactors the Store api into the driver (backend) implementation
and a client Store/StoreLike api. Store & StoreLike have their
sizes known at compile-time. This enables us to add templates
to the client-side to make it easier to work with, for example,
we no longer need to Pin the store and we'll be able to add
things like `digest: impl Into<DigestInfo>` to make the callers
life much easier.

towards: TraceMachina#934
allada added a commit to allada/nativelink-fork that referenced this issue Jun 4, 2024
@allada
Refactor Store API to use StoreKey
f3554fe 
This enables us to use arbitrary strings when using the Store API.

closes TraceMachina#934
allada added a commit to allada/nativelink-fork that referenced this issue Jun 4, 2024
@allada
Refactor Store Api into client side and driver side
d012c02 
Refactors the Store api into the driver (backend) implementation
and a client Store/StoreLike api. Store & StoreLike have their
sizes known at compile-time. This enables us to add templates
to the client-side to make it easier to work with, for example,
we no longer need to Pin the store and we'll be able to add
things like `digest: impl Into<DigestInfo>` to make the callers
life much easier.

towards: TraceMachina#934
allada added a commit that referenced this issue Jun 4, 2024
@allada
Refactor Store Api into client side and driver side (#935)
04beafd 
Refactors the Store api into the driver (backend) implementation
and a client Store/StoreLike api. Store & StoreLike have their
sizes known at compile-time. This enables us to add templates
to the client-side to make it easier to work with, for example,
we no longer need to Pin the store and we'll be able to add
things like `digest: impl Into<DigestInfo>` to make the callers
life much easier.

towards: #934
allada added a commit to allada/nativelink-fork that referenced this issue Jun 4, 2024
@allada
Refactor Store API to use StoreKey
a5276b7 
This enables us to use arbitrary strings when using the Store API.

closes TraceMachina#934
allada added a commit to allada/nativelink-fork that referenced this issue Jun 4, 2024
@allada
Refactor Store API to use StoreKey
e57c179 
This enables us to use arbitrary strings when using the Store API.

closes TraceMachina#934
allada added a commit that referenced this issue Jun 4, 2024
@allada
Refactor Store API to use StoreKey (#964)
e524bbc 
This enables us to use arbitrary strings when using the Store API.

closes #934
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor Store API to use StoreKey allada/nativelink-fork
1 participant
@allada