Reduce references to self.state_manager.inner #1060
Conversation
Removed unused test method and relocated notify function in `add_action`.
There was a problem hiding this comment.
Lets hold off on this. I don't love removing one notify call to add three more. We should plan out a proper API for this so that it doesn't create more debt when attempting to move to the subscribe API later.
Reviewable status: 0 of 1 LGTMs obtained, and pending CI: Cargo Dev / macos-13, Installation / macos-13, Local / ubuntu-22.04, Publish image, Publish nativelink-worker-init, Publish nativelink-worker-lre-cc, Remote / large-ubuntu-22.04
There was a problem hiding this comment.
There is already notify calls in that code path, can refactor it to be single notify tho it requires refactoring the add action call so the flow is easier to follow. I prefer to land this to get simple scheduler out of the way for integration
Reviewable status: 0 of 1 LGTMs obtained
Description
Removed unused test method and relocated notify function in
add_action.Fixes #1059
Type of change
Please delete options that aren't relevant.
Checklist
bazel test //...passes locallygit amendsee some docsThis change is