Upgrade rand crate version and stabalize test rand generation #1583
Conversation
There was a problem hiding this comment.
Reviewable status: 0 of 1 LGTMs obtained, and 0 of 31 files reviewed, and pending CI: Analyze (javascript-typescript), Analyze (python), Bazel Dev / macos-13, Bazel Dev / macos-14, Bazel Dev / ubuntu-24.04, Cargo Dev / macos-13, Cargo Dev / ubuntu-22.04, Coverage, Installation / macos-13, Installation / macos-14, Installation / ubuntu-22.04, Local / lre-cc / ubuntu-24.04, Local / lre-rs / macos-14, Local / lre-rs / ubuntu-24.04, NativeLink.com Cloud / Remote Cache / macos-14, NativeLink.com Cloud / Remote Cache / ubuntu-24.04, Publish image, Publish nativelink-worker-init, Publish nativelink-worker-lre-cc, Remote / lre-cc / large-ubuntu-22.04, Remote / lre-rs / large-ubuntu-22.04, Web Platform Deployment / ubuntu-24.04, asan / ubuntu-22.04, docker-compose-compiles-nativelink (22.04), integration-tests (22.04), macos-13, pre-commit-checks, ubuntu-20.04 / stable, ubuntu-22.04, ubuntu-22.04 / stable, vale, windows-2022 / stable (waiting on @aaronmondal)
allada
force-pushed
the
upgrade-rand-crate
branch
from
bedfbca to
512282d
Compare
allada
force-pushed
the
upgrade-rand-crate
branch
from
512282d to
148fcc0
Compare
allada
force-pushed
the
upgrade-rand-crate
branch
from
148fcc0 to
fcb8f45
Compare
There was a problem hiding this comment.
Reviewed 31 of 31 files at r1, all commit messages.
Reviewable status: 1 of 1 LGTMs obtained, and all files reviewed, and pending CI: Analyze (javascript-typescript), Analyze (python), Bazel Dev / macos-13, Bazel Dev / macos-14, Bazel Dev / ubuntu-24.04, Cargo Dev / macos-13, Cargo Dev / ubuntu-22.04, Coverage, Installation / macos-13, Installation / macos-14, Installation / ubuntu-22.04, Local / lre-cc / ubuntu-24.04, Local / lre-rs / macos-14, Local / lre-rs / ubuntu-24.04, NativeLink.com Cloud / Remote Cache / macos-14, NativeLink.com Cloud / Remote Cache / ubuntu-24.04, Publish image, Publish nativelink-worker-init, Publish nativelink-worker-lre-cc, Remote / lre-cc / large-ubuntu-22.04, Remote / lre-rs / large-ubuntu-22.04, Web Platform Deployment / ubuntu-24.04, asan / ubuntu-22.04, docker-compose-compiles-nativelink (22.04), integration-tests (22.04), macos-13, pre-commit-checks, ubuntu-20.04 / stable, ubuntu-22.04, ubuntu-22.04 / stable, windows-2022 / stable
There was a problem hiding this comment.
Reviewable status: 1 of 1 LGTMs obtained, and all files reviewed, and pending CI: Remote / lre-cc / large-ubuntu-22.04, docker-compose-compiles-nativelink (22.04), and 1 discussions need to be resolved
-- commits line 2 at r1:
nit: "stabilize"
Upgrades the rand crate version and ensures that every new test gets a new random seed by default.
allada
force-pushed
the
upgrade-rand-crate
branch
from
fcb8f45 to
21bdb36
Compare
There was a problem hiding this comment.
Reviewable status: 1 of 1 LGTMs obtained, and 20 of 31 files reviewed, and pending CI: pre-commit-checks
Previously, aaronmondal (Aaron Siddhartha Mondal) wrote…
nit: "stabilize"
Done.
There was a problem hiding this comment.
Reviewable status: 1 of 1 LGTMs obtained, and 20 of 31 files reviewed
There was a problem hiding this comment.
Reviewed 1 of 31 files at r1, 11 of 11 files at r2.
Reviewable status:complete! 1 of 1 LGTMs obtained, and all files reviewed
Upgrades the rand crate version and ensures that every new test
gets a new random seed by default.
This change is