Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added function to get base of a SDD-Node and tests #18

Merged
merged 2 commits into from
Jun 17, 2020

Conversation

shreyas-kowshik
Copy link
Contributor

@YitaoLiang Added the function as discussed.

@codecov-commenter
Copy link

codecov-commenter commented Jun 16, 2020

Codecov Report

Merging #18 into master will increase coverage by 0.29%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #18      +/-   ##
==========================================
+ Coverage   61.81%   62.11%   +0.29%     
==========================================
  Files          26       26              
  Lines        1946     1961      +15     
==========================================
+ Hits         1203     1218      +15     
  Misses        743      743              
Impacted Files Coverage Δ
src/Logical/LogicalCircuits.jl 69.69% <100.00%> (+8.91%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 029a318...7fcb443. Read the comment docs.

Copy link
Collaborator

@khosravipasha khosravipasha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good to me, feel free to merge.

One question about naming, is base a common terminalogy used in this context?

@shreyas-kowshik
Copy link
Contributor Author

@khosravipasha Base makes more sense for PSDD nodes rather than SDD nodes, I suppose.
Is there any other name you suggest for this?

@khosravipasha
Copy link
Collaborator

it's good I was just wondering what it means.

@YitaoLiang
Copy link
Collaborator

yeah, base is usually a concept associated with PSDD. It refers to the SDD (i.e. disregarding the parameters). Here, perhaps "to_string" would make sense?

@YitaoLiang
Copy link
Collaborator

Otherwise, it looks good to me. There could be some corner cases failing. But we can discuss that later, and update the code accordingly.

@khosravipasha
Copy link
Collaborator

Yeah, then something like get_base_string or get_base_str makes sense.

@shreyas-kowshik
Copy link
Contributor Author

@khosravipasha Changed the name to to_string as using base does not seem to make sense in this context. Also made changes to accomodated StructLogicalNodes along with $\Delta$Node

@khosravipasha
Copy link
Collaborator

Sounds great, thanks for the change.

@khosravipasha khosravipasha merged commit 67d98a0 into Tractables:master Jun 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants