-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added function to get base of a SDD-Node and tests #18
Conversation
Codecov Report
@@ Coverage Diff @@
## master #18 +/- ##
==========================================
+ Coverage 61.81% 62.11% +0.29%
==========================================
Files 26 26
Lines 1946 1961 +15
==========================================
+ Hits 1203 1218 +15
Misses 743 743
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good to me, feel free to merge.
One question about naming, is base
a common terminalogy used in this context?
@khosravipasha |
it's good I was just wondering what it means. |
yeah, base is usually a concept associated with PSDD. It refers to the SDD (i.e. disregarding the parameters). Here, perhaps "to_string" would make sense? |
Otherwise, it looks good to me. There could be some corner cases failing. But we can discuss that later, and update the code accordingly. |
Yeah, then something like |
@khosravipasha Changed the name to |
Sounds great, thanks for the change. |
@YitaoLiang Added the function as discussed.