Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to dataframes 1.x #94

Merged
merged 1 commit into from
Aug 27, 2021
Merged

Upgrade to dataframes 1.x #94

merged 1 commit into from
Aug 27, 2021

Conversation

khosravipasha
Copy link
Collaborator

Biggest changes are:

  1. Cannot do DataFrame(matrix) anymore, and need to either do DataFrame(matrix, :auto) or DataFrame(Tables.table(matrix)).

  2. Cannot use Base.convert for converting DataFrame to matrix, should use Tables.matrix(dataframe) instead.

@codecov
Copy link

codecov bot commented Aug 27, 2021

Codecov Report

Merging #94 (aa712c5) into master (5c69413) will increase coverage by 0.03%.
The diff coverage is 80.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #94      +/-   ##
==========================================
+ Coverage   88.08%   88.11%   +0.03%     
==========================================
  Files          31       31              
  Lines        3197     3198       +1     
==========================================
+ Hits         2816     2818       +2     
+ Misses        381      380       -1     
Impacted Files Coverage Δ
src/queries/satisfies.jl 62.24% <ø> (ø)
src/queries/satisfies_flow.jl 47.18% <0.00%> (ø)
src/LoadSave/data_loaders.jl 50.00% <50.00%> (+2.17%) ⬆️
src/Utils/data.jl 81.76% <100.00%> (ø)
src/transformations.jl 96.14% <0.00%> (+0.32%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c69413...aa712c5. Read the comment docs.

@khosravipasha khosravipasha merged commit 7d02b9c into master Aug 27, 2021
@khosravipasha khosravipasha deleted the dataframes-upgrade branch August 27, 2021 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant