Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permission to USE TradeShop #117

Closed
3 tasks done
LKits opened this issue Dec 28, 2021 · 7 comments · Fixed by #118
Closed
3 tasks done

Permission to USE TradeShop #117

LKits opened this issue Dec 28, 2021 · 7 comments · Fixed by #118
Assignees

Comments

@LKits
Copy link

LKits commented Dec 28, 2021

Is your feature request related to a problem?

No

Describe the solution you'd like.

Please add a permission to USE TradeShop.
So I can give permission to specific group that can use TradeShop.

For example:
tradeshop.use

Describe alternatives you've considered.

At the moment aren't any.

Agreements

  • I have searched for and ensured there isn't already an open issue regarding this.
  • I have ensured the feature I'm requesting isn't already in the latest supported TradeShop build.
  • I have asked the Developers and they have confirmed that it is not already in development.

Other

No response

@SparklingComet
Copy link
Member

Hi there, thanks for the suggestion.
As a counter-suggestion, how about adding a permission (such as tradeshop.noTrade) to stop users from buying from shops instead?
I believe this would also be a solution to the situation you pointed out on Discord.

@LKits
Copy link
Author

LKits commented Dec 30, 2021

tradeshop.noTrade doesn't seem to be doing anything.
Permission group that I added "tradeshop.noTrade allow" to can still buy from the shop.

@SparklingComet
Copy link
Member

There seems to be a misunderstanding. That permission does not yet exist, we're suggesting to add it.

@LKits
Copy link
Author

LKits commented Dec 30, 2021

That would certainly solve my situation. And I understand why you don't want to add "whitelist" permission, then your plugin wouldn't work "out-of-box".
"Blacklist" permission would work great!

@SparklingComet
Copy link
Member

That would certainly solve my situation. And I understand why you don't want to add "whitelist" permission, then your plugin wouldn't work "out-of-box".

Yes that is part of the rationale. Alright then, we'll add this to the todo list for the next release.

@KillerOfPie
Copy link
Collaborator

KillerOfPie commented Jan 4, 2022

@LKits Try out the newest dev release and let me know if it functions the way you need it to

The permission is tradeshop.prevent-trade

@LKits
Copy link
Author

LKits commented Jan 4, 2022

Works perfectly, thank you very much!

@LKits LKits closed this as completed Jan 4, 2022
@KillerOfPie KillerOfPie reopened this Jan 5, 2022
@KillerOfPie KillerOfPie linked a pull request Jan 5, 2022 that will close this issue
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants