Skip to content

Commit

Permalink
Fixed missing prefix in update output
Browse files Browse the repository at this point in the history
  • Loading branch information
Tranquility2 committed Jan 26, 2024
1 parent d9b7257 commit 5f060f3
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 6 deletions.
7 changes: 3 additions & 4 deletions src/semvergit/app.py
Original file line number Diff line number Diff line change
Expand Up @@ -72,15 +72,14 @@ def remove_prefix(text: str, prefix: str) -> str:
def update(self, bump_type: str, dry_run: bool, commit_message: Optional[str], auto_message: bool) -> str:
"""Update."""
new_version = self.latest_version.next_version(part=bump_type, prerelease_token=self.prerelease_token)
new_version_str = str(new_version)
logger.info(f"Update from {self.latest_version} with {bump_type} to {new_version}")
new_tag_str = f"{self.version_prefix}{new_version}"

if dry_run:
logger.warning("Dry run (no tag set or pushed)")

if auto_message:
commit_message = f"New version: {new_version_str}"
commit_message = f"New version: {str(new_version)}"
if auto_message or commit_message:
logger.info("Committing...")
new_commit(repo=self.current_repo, message=commit_message, dry_run=dry_run)
Expand All @@ -92,5 +91,5 @@ def update(self, bump_type: str, dry_run: bool, commit_message: Optional[str], a
push_remote(repo=self.current_repo, tag_str=new_tag_str, dry_run=dry_run)

logger.success(f"New version tag: {new_tag_str}")
sys.stdout.write(new_version_str)
return str(new_version_str)
sys.stdout.write(new_tag_str)
return str(new_tag_str)
4 changes: 2 additions & 2 deletions tests/test_app.py
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,6 @@ def test_app_update( # pylint: disable=too-many-arguments
if commit_message or auto_message:
assert "Committing..." in caplog.messages
assert "Pushing..." in caplog.messages
assert capsys.readouterr().out == str(expected_version)
assert new_version == str(expected_version)
assert capsys.readouterr().out == expected_tag_str
assert new_version == expected_tag_str
assert f"New version tag: {expected_tag_str}" in caplog.messages

0 comments on commit 5f060f3

Please sign in to comment.