-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Water results in "WATER O 15" (PUBCHEM.COMPOUND:10129877) in NameRes because of a conflation issue #264
Comments
I think 3 is fine. But I wonder if we can handle this at a per-clique level. We're merging a series of cliques, and each clique has a type. Can we have a preferred series of types and then just choose our favorite type from across the cliques? Drug at bottom, small molecule at top? |
Discussion result:
|
gaurav
added a commit
that referenced
this issue
Apr 16, 2024
gaurav
added a commit
that referenced
this issue
Apr 22, 2024
We previously used a randomly chosen identifier from each DrugChemical conflation to choose the Biolink type for the entire conflation, which would also determine the order of prefixes within the conflation. This lead to issues where we used an RXCUI to determine that a conflation should be considered a biolink:Drug, when really biolink:SmallMolecule would be a better type. Instead, this PR replaces that approach with a preferred-type approach. Also replaces COMPLEX_CHEMICAL_MIXTURE with COMPLEX_MOLECULAR_MIXTURE, which is what Biolink calls it now. Closes #264.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This is because NameRes entries are all based on DrugConflated results, and the conflation for water is:
So why is PUBCHEM.COMPOUND:10129877 ("WATER O 15") ranked above CHEBI:15377 ("water")? This is because after we generate the initial conflation, the leading ID is RXCUI:1425974 ("Opticlear"), which is a biolink:Drug. As a biolink:Drug, PUBCHEM.COMPOUND is a more preferred prefix than CHEBI:
So, options for fixing this:
The text was updated successfully, but these errors were encountered: