Move DrugChemical synonyms into subdirectory #248
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is harder to implement than I expected, because it would require modifying write_compendium() so it can write compendia and synonym files into different locations, which will be a lot of work. Closing branch. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently create a DrugChemicalConflated.txt synonyms file using the DrugChemical conflation information to combine cliques. However, we still include synonym names for each individual chemical output (i.e. SmallMolecule.txt, Drug.txt, and so on). This PR moves those files into a subdirectory, so we still create those files, but they are in a separate directory so a user won't get confused and accidentally use both DrugChemicalConflated.txt and the redundant synonyms in the individual chemical output files.