Add an autocomplete flag
#118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbizon
approved these changes
Nov 22, 2023
gaurav
force-pushed
the
add-autocomplete-flag
branch
from
00bb9c2 to
3992dab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NameRes' /lookup endpoint was previously designed for the autocomplete use-case, where we expect to give good results even when the search term is incomplete (e.g.
diabinstead ofdiabetes). We handled this by expanding the search to({query}) OR ({query}*). This PR adds anautocompleteflag that allows this expansion to be turned on and off -- this should help improve our accuracy when NameRes is used for named entity linking only.Closes #108.