Added support for multitype filtering #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaurav
added a commit
that referenced
this pull request
Aug 30, 2024
The previous PR (#158) introduced a bug that could be triggered by sending biolink_type='' to NameRes. This PR fixes that issue, and adds a test for this to the test suite.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for multitype filtering without changing the API: you can continue to use
biolink_type=Diseaseif you want to filter with a single Biolink type, but you can also specifybiolink_type=Disease&biolink_type=PhenotypicFeatureif you want to find concepts that are EITHER (not both) biolink:Disease or biolink:PhenotypicFeature.Closes #157.