Replaces /reverse_lookup with a more sensible name. #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbizon
approved these changes
Nov 4, 2024
gaurav
added a commit
that referenced
this pull request
Nov 7, 2024
Unfortunately, #168 renamed the parameter for the deprecated endpoint /reverse_lookup from curies to preferred_curies. This PR undoes that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've had a lot of users getting confused because a CURIE that works in NodeNorm doesn't work in NameLookup -- this is because NameLookup's
/reverse_lookupendpoint doesn't do any normalization. This PR deprecates those endpoints (while leaving them around), and adds new/synonymsendpoints, which explicitly call thempreferred_curiesand has a note in the description to indicate that NodeNorm should be used to get these./synonymsisn't quite accurate, because really this endpoint returns all the information we have on that CURIE, including the suffix, taxon information and so on. But the obvious correct name (/lookup) is already in use for NameLookup's text search function.Closes #136.