New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: moving logic to terminate method #97

Merged

JustSteveKing merged 1 commit into master from feature/refactor-to-terminate

Oct 9, 2024

Contributor

JustSteveKing commented Oct 9, 2024

This PR moves the main logic to the terminate method, for the rare cases that the 'handle' method isn't called but terminate is.

I have also moved the random Endpoint selection to a static method on the Enum itself.

This means I have had to remove a test for checking if the header is set for X-TREBLLE-TRACE-ID as terminate is a void return.


          fix: moving logic to terminate method

a7d3056

JustSteveKing merged commit 931f721 into master

5 checks passed

JustSteveKing deleted the feature/refactor-to-terminate branch

October 9, 2024 10:47

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet