Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG]: The 'search-bar-loading-state' attribute does not function properly with Boolean values #774

Closed
1 task
erbilnas opened this issue Jan 18, 2024 · 2 comments · Fixed by #775
Closed
1 task

[BUG]: The 'search-bar-loading-state' attribute does not function properly with Boolean values #774

erbilnas opened this issue Jan 18, 2024 · 2 comments · Fixed by #775
Labels
bl-select Select Component bug Something isn't working released on @beta released

Comments

@erbilnas
Copy link
Collaborator

Issue description

:search-bar-loading-state="isStoreLoading || undefined"

When attempting to set this attribute, it doesn't accept boolean values, and I'm required to provide 'undefined' to remove it from the DOM. It should ideally accept boolean values.

Media & Screenshots

No response

Baklava Version

2.4.0-beta.12

Operating system

  • OS: macOS Sonoma 14.2 (23C64)
  • Browser: Microsoft Edge Version 120.0.2210.133 (Official build) (arm64)
  • Web Framework: Vue 3.4.7

Priority this issue should have

Medium (should be fixed soon)

Please review the checkboxes that are applicable.

  • This issue is directly related to React
@erbilnas erbilnas added bug Something isn't working bl-select Select Component labels Jan 18, 2024
@erbilnas erbilnas mentioned this issue Jan 18, 2024
Merged
leventozen pushed a commit that referenced this issue Jan 18, 2024
@erbilnas
fix(select): add string to boolean converter for related prop (#775)
e032b7a 
No breaking change | Closes #774

Co-authored-by: Erbil Nas <[email protected]>
@github-actions GitHub Actions
Copy link

🎉 This issue has been resolved in version 2.4.0-beta.14 🎉

The release is available on:

Your semantic-release bot 📦🚀

@leventozen leventozen mentioned this issue Jan 25, 2024
Closed
@github-actions GitHub Actions
Copy link

🎉 This issue has been resolved in version 3.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bl-select Select Component bug Something isn't working released on @beta released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(select): add string to boolean converter for related prop Trendyol/baklava
1 participant
@erbilnas