feat: codecov support #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! I triggered this workflow but I guess the report has some issues. Do you know why we are seeing this? |
|
@erkanzileli Thanks for approval. I guess Codecov Github App is missing, are you authorized to add that integration on Trendyol account? |
|
@bilalcaliskan thanks for the PR, looks great 🤝👌 Maybe as you said, @erkanzileli has not enough permissions to do that, I'll check it out ASAP. 🙋🏻♂️ |
|
The app is added and I re-triggered but I guess it's still the same. Maybe because there are no tests currently or this change is not on the main branch. Other than that LGTM. Maybe we can merge it and see what happens. |
|
@erkanzileli I think it's working now, i guess coverage seems %0 on readme because of that there are no tests yet as you mentioned. Thanks for merging! |
developer-guy
added a commit
that referenced
this pull request
Dec 23, 2024
Signed-off-by: Batuhan Apaydın <[email protected]> fix(cmd): should not error out twice Fixes #3 Signed-off-by: Furkan <[email protected]> fix(run): update service if exist Fixes #2 Signed-off-by: Furkan <[email protected]> feat: license lint error fixed, detect and work with current namespace in kubeconfig, enhance delete message with force mode enabled Fixes #1 Signed-off-by: Batuhan Apaydın <[email protected]> feat(load): pull image if it is not exist on locally Fixes #5 Signed-off-by: Batuhan Apaydın <[email protected]> build: release cycle created with github actions Signed-off-by: Batuhan Apaydın <[email protected]> style: Update README.md Signed-off-by: Batuhan Apaydın <[email protected]> chore: impl cosign support Signed-off-by: Furkan <[email protected]> feat(images): change container image repository addresses Signed-off-by: Batuhan Apaydın <[email protected]> add docker-images Signed-off-by: Furkan <[email protected]> chore: user kindest/node instead Signed-off-by: Furkan <[email protected]> fix(doc): add new line fix(doc): remove new line fix(doc): add new line (#4) Co-authored-by: Erkan Zileli <[email protected]> chore(goreleaser): add homebrew integration (#5) doc(completion): fix completion docs (#10) fix(goreleaser): remove completions from brew Signed-off-by: Erkan Zileli <[email protected]> feat: make skip_upload true Signed-off-by: Batuhan Apaydın <[email protected]> build(deps): bump github.com/schollz/progressbar/v3 from 3.8.2 to 3.8.3 (#12) * feat: make skip_upload true Signed-off-by: Batuhan Apaydın <[email protected]> * build(deps): bump github.com/schollz/progressbar/v3 from 3.8.2 to 3.8.3 Bumps [github.com/schollz/progressbar/v3](https://github.com/schollz/progressbar) from 3.8.2 to 3.8.3. - [Release notes](https://github.com/schollz/progressbar/releases) - [Commits](schollz/progressbar@v3.8.2...v3.8.3) --- updated-dependencies: - dependency-name: github.com/schollz/progressbar/v3 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Batuhan Apaydın <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> build(deps): bump github.com/AlecAivazis/survey/v2 from 2.2.16 to 2.3.2 (#11) Bumps [github.com/AlecAivazis/survey/v2](https://github.com/AlecAivazis/survey) from 2.2.16 to 2.3.2. - [Release notes](https://github.com/AlecAivazis/survey/releases) - [Commits](AlecAivazis/survey@v2.2.16...v2.3.2) --- updated-dependencies: - dependency-name: github.com/AlecAivazis/survey/v2 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> docs(readme): add new badges feat: add .golangci.yaml feat: add test workflow docs(readme): edit badges feat(goreleaser): add go proxy fix: lint,fmt issues Signed-off-by: Batuhan Apaydın <[email protected]> fix: github release project name Signed-off-by: Batuhan Apaydın <[email protected]> fix: change binary name Signed-off-by: Batuhan Apaydın <[email protected]> fix: add go 1.17.x to the matrix, remove dockerfile (#14) Signed-off-by: Erkan Zileli <[email protected]> feat: add completions script for goreleaser (#13) Signed-off-by: Erkan Zileli <[email protected]> fix: use only go1.17 on matrix for test workflow (#15) Signed-off-by: Erkan Zileli <[email protected]> fix: golint issues are fixed Signed-off-by: Erkan Zileli <[email protected]> docs(readme): fix commands, add homebrew installation section Signed-off-by: Batuhan Apaydın <[email protected]> docs(readme): remove sign/verify paragraphs docs(readme): make bold binary installation path feat: codecov support (#26) Fix hello-world command example (#27) feat: improve release and installation with MacOS (#47) build(deps): bump github.com/schollz/progressbar/v3 from 3.8.3 to 3.8.5 (#46) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds codecov integration on unit testing
Which issue(s) this PR related:
Implements second task on #7
Special notes for your reviewer:
This is my first PR to Trendyol open source, so i am very open to any kind of feedbacks!