Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use model_name in human_admin_name as default #251

Merged
merged 3 commits into from
Oct 30, 2019
Merged

use model_name in human_admin_name as default #251

merged 3 commits into from
Oct 30, 2019
+9 −1

Conversation

svoboda-jan
Copy link
Contributor

No description provided.

@svoboda-jan
use model_name in human_admin_name as default

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
38ffe44
@coveralls
Copy link

coveralls commented Oct 28, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.1%) to 84.989% when pulling 588d0af on svoboda-jan:patch-2 into d61193f on TrestleAdmin:master.

@spohlenz
Copy link
Member

The model_name method is only available in Trestle::Resource and not the top-level Trestle::Admin class. However I would be in favour of extracting the altered part of the line into a separate method such as default_human_admin_name that could be overridden in the Trestle::Resource subclass.

@svoboda-jan
add default_human_admin_name

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
0b1a2b6
@svoboda-jan
override default_human_admin_name

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
588d0af
@svoboda-jan
Copy link
Contributor Author

👍 Made the changes.

@spohlenz
Copy link
Member

Looks great. Thank you!

@spohlenz spohlenz merged commit c664f24 into TrestleAdmin:master Oct 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@svoboda-jan @coveralls @spohlenz