Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP:Use uvloop for reactor #5257

Closed
wants to merge 1 commit into from
Closed

WIP:Use uvloop for reactor #5257

wants to merge 1 commit into from

Conversation

ichorid
Copy link
Contributor

@ichorid ichorid commented Mar 29, 2020

No description provided.

@ichorid ichorid changed the title Use uvloop for reactor WIP:Use uvloop for reactor Mar 29, 2020
@ghost
Copy link

ghost commented Mar 29, 2020 •
edited by ghost
Loading

Congratulations 🎉. DeepCode analyzed your code in 1.132 seconds and we found no issues. Enjoy a moment of no bugs ☀️.

👉 View analysis in DeepCode’s Dashboard

devos50
devos50 suggested changes Mar 29, 2020
View reviewed changes
Copy link
Contributor

@devos50 devos50 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make sure that the uvloop is also executed in the unit tests? Using a different reactor in the tests and when running Tribler through the script might bite us later when debugging any error caused by the uvloop reactor.

Also, for every dependency we add, we should update the documentation on how to build/run Tribler on Windows, Linux and Mac.

@ichorid
Copy link
Contributor Author

ichorid commented Mar 29, 2020

Can we make sure that the uvloop is also executed in the unit tests? Using a different reactor in the tests and when running Tribler through the script might bite us later when debugging any error caused by the uvloop reactor.

Good point! I was thinking about that too. I'll try to install the reactor in the tests base.

@ichorid
Copy link
Contributor Author

ichorid commented Mar 30, 2020

retest this please

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@ichorid
Copy link
Contributor Author

ichorid commented Mar 30, 2020

There is no stable Windows implementation of uvloop. Closing this.

@ichorid ichorid closed this Mar 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devos50 devos50 devos50 requested changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ichorid @devos50