MANTA-3233 Undeploy without disruption - moray

[joyent-automation]

MANTA-3233 Undeploy without disruption - moray

This PR was migrated-from-gerrit, https://cr.joyent.us/#/c/3092/.
The raw archive of this CR is here.
See MANTA-4594 for info on Joyent Eng's migration from Gerrit.

CR discussion

@melloc commented at 2017-12-12T01:11:22

Patch Set 1:

(4 comments)

Patch Set 1 code comments

lib/server.js#336 @melloc

Just "Moray" here and below.

lib/server.js#336 @timkordas

yep. I copied this verbatim from electric-moray.

fixed.

lib/server.js#353 @melloc

I think this would be better off as a method on the MorayServer object.

lib/server.js#365 @melloc

Should we wait to close the monitoring server? If a server's stuck quiescing, this'll allow us to poke at it.

lib/server.js#365 @timkordas

good point.

moved.

also ported your comment to the electric moray CR: https://cr.joyent.us/#/c/2932/

lib/server.js#383 @melloc

It seems like we should be able to just call MorayServer.close() once we get here.

lib/server.js#383 @timkordas

yep. that is certainly cleaner than this. fixed.

@timkordas commented at 2017-12-12T18:00:27

Patch Set 3:

(3 comments)

Patch Set 3 code comments

lib/server.js#366 @joyent-automation

warning: undeclared identifier: server

lib/server.js#367 @joyent-automation

warning: undeclared identifier: server

@melloc commented at 2017-12-15T20:01:34

Patch Set 4:

(1 comment)

Patch Set 4 code comments

lib/server.js#217 @melloc

Thinking about this some more, I think that it would be good to do this in main.js instead, when the "listening" event fires. When that happens, we can then call a server.quiesce() method which will kick everything off. This will be friendlier to consumers who use Moray as an embedded library, so that we're not registering a SIGTERM handler in their process, and they can choose when to call .quiesce() themselves.