PUBAPI-1146 Divorce wanted between *_KEY_ID env vars and keyId actually sent to server #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ly sent to server
arekinath
force-pushed
the
pubapi-1146
branch
from
6db683a to
a2b68d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates
node-smartdcto use the latest version ofsmartdc-auth, which has incorporated support for the new-style base64 SSH key fingerprints, amongst other improvements.The original PR on smartdc-auth (TritonDataCenter/node-smartdc-auth#3) has a lot more information about exactly what has changed.
Other than updating the dependency version, this patch simply relaxes the RegExp used to validate the
SDC_KEY_IDenv var, and makes use of the newsubuseroption provided tocliSigner.