Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove remaining usage of jodid25519 #28

Closed
pravi opened this issue May 3, 2017 · 1 comment
Closed

remove remaining usage of jodid25519 #28

pravi opened this issue May 3, 2017 · 1 comment

Comments

@pravi
Copy link

pravi commented May 3, 2017

jodid25519 is not maintained anymore and its author recommends switching to tweetnacl.

meganz/jodid25519#10 (comment)
@arekinath arekinath changed the title please switch to tweetnacl from jodid25519 remove remaining usage of jodid25519 May 5, 2017
@arekinath
Copy link

So, progress on removing jodid25519 began when we first brought in the tweetnacl dependency, back in 1.6.0 (we're currently at 1.13.0). It looks like the only thing left using jodid25519 is the support for X25519 DH, which is pretty easy to change over.

I've made https://cr.joyent.us/#/c/1911/ to change over this last piece

joyent-automation pushed a commit that referenced this issue Jun 8, 2017
#28 remove remaining usage of jodid25519
a17ec88 
#30 curve25519 keys should always have size 256
Reviewed by: Cody Peter Mello <[email protected]>
This was referenced Apr 12, 2019
Closed
Closed
@dependabot dependabot bot mentioned this issue Jul 12, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@arekinath @pravi