Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x509 cert string type mangling breaks chains #40

Closed
arekinath opened this issue Dec 7, 2017 · 2 comments
Closed

x509 cert string type mangling breaks chains #40

arekinath opened this issue Dec 7, 2017 · 2 comments

Comments

@arekinath
Copy link

arekinath commented Dec 7, 2017 •
edited
Loading

According to the X509 RFC, cert chain validators are free to assume that if a DN attribute's string types differ, they are not a valid match. Currently, the x509 generation code in identity.js always generates PrintableString attribute values where the characters in the string can be contained in the ASCII set. This unfortunately means that if we, say, read in a certificate that has UTF8String attributes in its subject DN and copy that into a new certificate's issuer DN, some implementations (notably libnss) will not consider the resulting certificate's issuer DN and the other cert's subject DN to be a match, and will not follow the signing chain.
joyent-automation pushed a commit that referenced this issue Dec 8, 2017
#40 x509 cert string type mangling breaks chains
69d24bc 
Reviewed by: Cody Peter Mello <[email protected]>
Approved by: Cody Peter Mello <[email protected]>
@roccomuso
Copy link

is this change gonna be merged?

@arekinath
Copy link
Author

Yeah, this will be released as part of 1.13.2 today.

This was referenced Oct 10, 2018
Merged
Merged
@dependabot-preview dependabot-preview bot mentioned this issue Dec 30, 2018
Closed
This was referenced Apr 12, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced May 31, 2019
Merged
Open
Closed
Merged
@dependabot dependabot bot mentioned this issue Jul 12, 2019
Merged
@dependabot-preview dependabot-preview bot mentioned this issue Jul 19, 2019
Closed
@dependabot dependabot bot mentioned this issue Aug 15, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@arekinath @roccomuso