Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow spaces in the SSH ControlPath #334

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

blackwood821
Copy link

This addresses #240

@bahamat
Copy link
Contributor

bahamat commented Jun 13, 2023

This looks good, but we'd like to see some testing cases with example output.

@blackwood821
Copy link
Author

@bahamat Here is what we were getting before my change:

C:\Users\Test User>triton ssh sandbox
command-line line 0: garbage at end of line; "User\\AppData\\Roaming\\Joyent\\Triton\\tmp\\nullSshControlPath"

And here is what we got after my change:

C:\Users\Test User>triton ssh sandbox
Warning: Permanently added '10.10.50.105' (ED25519) to the list of known hosts.

  ,---.                   |     ,---. ,---.
  `---. ,-.-. ,---. ,---. |---  |   | `---.  base-64-lts
      | | | | ,---| |     |     |   |     |  22.4.0
  `---' ` ' ' `---' `     `---' `---' `---'

[root@sandbox ~]# 

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants