Remove syscall.Dup2() support. #492
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a breaking change, but it is time to rip the bandaid off. `syscall.Dup2()` will never be merged upstream[1]. Software depending on `syscall.Dup2()` needs to move to use `unix.Dup2()`. [1] https://docs.google.com/document/d/1QXzI9I1pOfZPujQzxhyRy6EeHYTQitKKjHfpq0zpxZs/edit [2] https://godoc.org/golang.org/x/sys/unix#Dup2
|
I think L89-90 of |
…syscall` package.
|
Good catch, PR updated. |
jen20
approved these changes
Apr 28, 2017
|
I committed this change to lang/go on trunk now. |
|
At least the Go packages that pkgsrc has are fine with this. |
jsonn
referenced
this pull request
in jsonn/pkgsrc
May 2, 2017
…ing unix.Dup2() instead. https://github.com/joyent/pkgsrc/pull/492 * Improve handling of low-memory situations on Illumos. https://github.com/joyent/pkgsrc/pull/493
mamash
referenced
this pull request
May 3, 2017
…ing unix.Dup2() instead. https://github.com/joyent/pkgsrc/pull/492 * Improve handling of low-memory situations on Illumos. https://github.com/joyent/pkgsrc/pull/493
|
The updated go-1.8.1nb2 package just landed in 2016Q4, though the mirrors might take an hour or so to synchronize. |
jsonn
referenced
this pull request
in jsonn/pkgsrc
May 6, 2017
lang/go: bugfix
Revisions pulled up:
- lang/go/Makefile 1.51
- lang/go/distinfo 1.47
- lang/go/patches/patch-src_runtime_mem__bsd.go 1.1
- lang/go/patches/patch-src_syscall_syscall__solaris.go deleted
---
Module Name: pkgsrc
Committed By: fhajny
Date: Tue May 2 17:15:31 UTC 2017
Modified Files:
pkgsrc/lang/go: Makefile distinfo
Added Files:
pkgsrc/lang/go/patches: patch-src_runtime_mem__bsd.go
Removed Files:
pkgsrc/lang/go/patches: patch-src_syscall_syscall__solaris.go
Log Message:
* Remove patch adding syscall.Dup2() for SunOS, software should be using
unix.Dup2() instead.
https://github.com/joyent/pkgsrc/pull/492
* Improve handling of low-memory situations on Illumos.
https://github.com/joyent/pkgsrc/pull/493
netbsd-srcmastr
referenced
this pull request
in NetBSD/pkgsrc
Jun 9, 2017
lang/go: bugfix
Revisions pulled up:
- lang/go/Makefile 1.51
- lang/go/distinfo 1.47
- lang/go/patches/patch-src_runtime_mem__bsd.go 1.1
- lang/go/patches/patch-src_syscall_syscall__solaris.go deleted
---
Module Name: pkgsrc
Committed By: fhajny
Date: Tue May 2 17:15:31 UTC 2017
Modified Files:
pkgsrc/lang/go: Makefile distinfo
Added Files:
pkgsrc/lang/go/patches: patch-src_runtime_mem__bsd.go
Removed Files:
pkgsrc/lang/go/patches: patch-src_syscall_syscall__solaris.go
Log Message:
* Remove patch adding syscall.Dup2() for SunOS, software should be using
unix.Dup2() instead.
https://github.com/joyent/pkgsrc/pull/492
* Improve handling of low-memory situations on Illumos.
https://github.com/joyent/pkgsrc/pull/493
netbsd-srcmastr
referenced
this pull request
in NetBSD/pkgsrc
Jun 22, 2017
lang/go: bugfix
Revisions pulled up:
- lang/go/Makefile 1.51
- lang/go/distinfo 1.47
- lang/go/patches/patch-src_runtime_mem__bsd.go 1.1
- lang/go/patches/patch-src_syscall_syscall__solaris.go deleted
---
Module Name: pkgsrc
Committed By: fhajny
Date: Tue May 2 17:15:31 UTC 2017
Modified Files:
pkgsrc/lang/go: Makefile distinfo
Added Files:
pkgsrc/lang/go/patches: patch-src_runtime_mem__bsd.go
Removed Files:
pkgsrc/lang/go/patches: patch-src_syscall_syscall__solaris.go
Log Message:
* Remove patch adding syscall.Dup2() for SunOS, software should be using
unix.Dup2() instead.
https://github.com/joyent/pkgsrc/pull/492
* Improve handling of low-memory situations on Illumos.
https://github.com/joyent/pkgsrc/pull/493
jsonn
referenced
this pull request
in jsonn/pkgsrc
Jun 22, 2017
lang/go: bugfix
Revisions pulled up:
- lang/go/Makefile 1.51
- lang/go/distinfo 1.47
- lang/go/patches/patch-src_runtime_mem__bsd.go 1.1
- lang/go/patches/patch-src_syscall_syscall__solaris.go deleted
---
Module Name: pkgsrc
Committed By: fhajny
Date: Tue May 2 17:15:31 UTC 2017
Modified Files:
pkgsrc/lang/go: Makefile distinfo
Added Files:
pkgsrc/lang/go/patches: patch-src_runtime_mem__bsd.go
Removed Files:
pkgsrc/lang/go/patches: patch-src_syscall_syscall__solaris.go
Log Message:
* Remove patch adding syscall.Dup2() for SunOS, software should be using
unix.Dup2() instead.
https://github.com/joyent/pkgsrc/pull/492
* Improve handling of low-memory situations on Illumos.
https://github.com/joyent/pkgsrc/pull/493
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a breaking change, but it is time to rip the bandaid off.
syscall.Dup2()will never be merged upstream[1]. Software depending onsyscall.Dup2()needs to move to useunix.Dup2().[1] https://docs.google.com/document/d/1QXzI9I1pOfZPujQzxhyRy6EeHYTQitKKjHfpq0zpxZs/edit
[2] https://godoc.org/golang.org/x/sys/unix#Dup2