-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Triggering the stake limit increase event #805
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me but since this is a sensitive part of the chain I'd suggest adding proper testing
Codecov Report
@@ Coverage Diff @@
## develop #805 +/- ##
===========================================
+ Coverage 58.68% 58.73% +0.05%
===========================================
Files 73 73
Lines 4175 4222 +47
===========================================
+ Hits 2450 2480 +30
- Misses 1515 1531 +16
- Partials 210 211 +1 |
@shanev @jhernandezb Possible to get this in sometime this week? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have some questions.
So this isn't hidden: #805 (comment) |
Is this still an issue? Was never merged in for some reason. |
I think all issues were resolved but somehow was never merged in. |
Will have to update for utru anyway, so let's get this in after the utru migration. |
@mohitmamoria Can merge this after it's migrated to utru and the branch has been updated. |
Needed for TruStory/octopus#381.