Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Triggering the stake limit increase event #805

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

mohitmamoria
Copy link
Contributor

@mohitmamoria mohitmamoria commented Oct 4, 2019

Needed for TruStory/octopus#381.

Copy link
Contributor

@jhernandezb jhernandezb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me but since this is a sensitive part of the chain I'd suggest adding proper testing

x/staking/endblocker.go Show resolved Hide resolved
x/staking/endblocker.go Show resolved Hide resolved
x/staking/endblocker.go Show resolved Hide resolved
x/staking/endblocker.go Outdated Show resolved Hide resolved
x/staking/endblocker.go Show resolved Hide resolved
x/staking/endblocker.go Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Oct 8, 2019

Codecov Report

Merging #805 into develop will increase coverage by 0.05%.
The diff coverage is 63.82%.

@@             Coverage Diff             @@
##           develop     #805      +/-   ##
===========================================
+ Coverage    58.68%   58.73%   +0.05%     
===========================================
  Files           73       73              
  Lines         4175     4222      +47     
===========================================
+ Hits          2450     2480      +30     
- Misses        1515     1531      +16     
- Partials       210      211       +1

@mohitmamoria
Copy link
Contributor Author

@shanev @jhernandezb Possible to get this in sometime this week?

Copy link
Contributor

@shanev shanev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have some questions.

x/staking/endblocker.go Outdated Show resolved Hide resolved
x/staking/endblocker.go Show resolved Hide resolved
@shanev
Copy link
Contributor

shanev commented Oct 14, 2019

So this isn't hidden: #805 (comment)

@shanev
Copy link
Contributor

shanev commented Nov 15, 2019

Is this still an issue? Was never merged in for some reason.

@mohitmamoria
Copy link
Contributor Author

I think all issues were resolved but somehow was never merged in.

@shanev
Copy link
Contributor

shanev commented Nov 18, 2019

Will have to update for utru anyway, so let's get this in after the utru migration.

@shanev
Copy link
Contributor

shanev commented Nov 27, 2019

@mohitmamoria Can merge this after it's migrated to utru and the branch has been updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants