Check the size of the encrypted data to make sure there's at least enough bytes for the nonce #111

xoloki · 2024-12-18T03:32:04Z

No description provided.

…ough bytes for the nonce; add a test on both sides of that size boundary

djordon

What is here is okay, but we could have a more helpful error and make things a little more efficient using the get API.

src/util.rs

check the size of the encrypted data to make sure there's at least en…

4c2a51f

…ough bytes for the nonce; add a test on both sides of that size boundary

xoloki requested a review from djordon December 18, 2024 03:32

djordon approved these changes Dec 18, 2024

View reviewed changes

src/util.rs Outdated Show resolved Hide resolved

xoloki added 2 commits December 18, 2024 11:00

use slice get API; return specific error for missing data

5d08659

no need to ref a slice

24a6ee8

xoloki merged commit 3689ec6 into main Dec 18, 2024
5 checks passed

xoloki deleted the aes-slice branch December 18, 2024 16:07

xoloki restored the aes-slice branch December 18, 2024 16:07

djordon mentioned this pull request Dec 18, 2024

[Bug]: Signers can crash each other with invalid DkgPrivateShares stacks-network/sbtc#1162

Open

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Check the size of the encrypted data to make sure there's at least enough bytes for the nonce #111

Check the size of the encrypted data to make sure there's at least enough bytes for the nonce #111

xoloki commented Dec 18, 2024

djordon left a comment

Check the size of the encrypted data to make sure there's at least enough bytes for the nonce #111

Check the size of the encrypted data to make sure there's at least enough bytes for the nonce #111

Conversation

xoloki commented Dec 18, 2024

djordon left a comment

Choose a reason for hiding this comment