Fix $http error/success is deprecated warnings

[simison]

Running gulp eslint now warns:

modules/users/client/controllers/authentication.client.controller.js
  28:7  warning  $http error is deprecated. Use then or catch instead  angular/no-http-callback
  28:7  warning  $http success is deprecated. Use then instead         angular/no-http-callback

modules/users/client/controllers/confirm-email.client.controller.js
  28:7  warning  $http error is deprecated. Use then or catch instead  angular/no-http-callback
  28:7  warning  $http success is deprecated. Use then instead         angular/no-http-callback

modules/users/client/controllers/password-forgot.client.controller.js
  25:7  warning  $http error is deprecated. Use then or catch instead  angular/no-http-callback
  25:7  warning  $http success is deprecated. Use then instead         angular/no-http-callback

modules/users/client/controllers/password-reset.client.controller.js
  25:7  warning  $http error is deprecated. Use then or catch instead  angular/no-http-callback
  25:7  warning  $http success is deprecated. Use then instead         angular/no-http-callback

modules/users/client/controllers/profile-edit-account.client.controller.js
  92:7  warning  $http error is deprecated. Use then or catch instead  angular/no-http-callback
  92:7  warning  $http success is deprecated. Use then instead         angular/no-http-callback

modules/users/client/controllers/profile-edit-networks.client.controller.js
  53:7  warning  $http error is deprecated. Use then or catch instead  angular/no-http-callback
  53:7  warning  $http success is deprecated. Use then instead         angular/no-http-callback

modules/users/client/controllers/signup.client.controller.js
  94:7  warning  $http error is deprecated. Use then or catch instead  angular/no-http-callback
  94:7  warning  $http success is deprecated. Use then instead         angular/no-http-callback

From https://docs.angularjs.org/api/ng/service/$http:

The $http legacy promise methods success and error have been deprecated. Use the standard then method instead. If $httpProvider.useLegacyPromiseExtensions is set to false then these methods will throw $http/legacy error.

See also meanjs/mean#1479

[rpaggi]

Hello, i know how fix this, i'll act in this issue. When i finish i send my PR. (@rpaggi)

[simison]

Excellent, thanks!

On 12 Sep 2016 14:27, "Ronaldo Cesar Paggi" [email protected]
wrote:

Hello, i know how fix this, i'll act in this issue. When i finish i send
my PR.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#407 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAFUgPEd0AbZ9nH4aTvJfTbtOgjzfS3Wks5qpVNEgaJpZM4J05Kc
.

[rpaggi]

Hey @simison, help me to use gulp eslint command please. I need to run in the root project folder?
Thanks

[simison]

(replied via Telegram)

On 13 Sep 2016 02:32, "Ronaldo Cesar Paggi" [email protected]
wrote:

Hey @simison https://github.com/simison, help me to use gulp eslint
command please. I need to run in the root project folder?
Thanks

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#407 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAFUgHQyNhrXqKb6iuns59hN0Iuejau1ks5qpf0VgaJpZM4J05Kc
.