-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 753: Updating MongoDB #762
Conversation
Thanks! Looks like Running |
Thanks for working on this! I know this might've been a confusingly small task but I like to leave these out there for the community during the Hactoberfest.
Yap, only the background job worker script uses native driver directly for Agenda's connection (job runner library) — the server app itself uses Mongoose ODM at all levels. Agenda supports re-using Mongoose connection so we should harmonise the setup as a future iteration.
Trustroots DB name depends on environment config and is different for prod, dev and test envs. It's the last bit in these URIs: trustroots/config/env/development.js Line 15 in 3281c5c
trustroots/config/env/production.js Line 15 in 3281c5c
Line 15 in 3281c5c
Worker script gets this via |
This could be due missing They don't seem to fail on Travis CI currently (this branch shows up green as well). |
The driver is used by the background job worker script.
Hey,
This PR is in respect to issue 753
I've updated the code to fit with MongoDB v3.
Only two things that I noticed that needed changing was the fact the DB is now passed back to the client during the initial connection. I don't know what Trustroots DB name is, so it's left blank by default. The collection
'agendaJobs'
is then grabbed.Ran all tests as well as the scripts to populate the DB with fake data and it's failing on the profile picture tests. However, the
master
branch from my fork fails on this too?