Skip to content

Commit

Permalink
Fixed portal failure on opening email prefs for logged out member
Browse files Browse the repository at this point in the history
- opening email preferences page via portal link doesn't work if member is not logged in.
- opens the signin page now instead of silently crashing
  • Loading branch information
rishabhgrg committed Jan 12, 2023
1 parent 28bea79 commit ee7474d
Showing 1 changed file with 5 additions and 4 deletions.
9 changes: 5 additions & 4 deletions ghost/portal/src/components/pages/AccountEmailPage.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,6 @@ const React = require('react');

export default function AccountEmailPage() {
const {member, onAction, site} = useContext(AppContext);
const defaultSubscribedNewsletters = [...(member?.newsletters || [])];
const [subscribedNewsletters, setSubscribedNewsletters] = useState(defaultSubscribedNewsletters);
const {comments_enabled: commentsEnabled} = site;
const {enable_comment_notifications: enableCommentNotifications} = member;

useEffect(() => {
if (!member) {
Expand All @@ -20,6 +16,11 @@ export default function AccountEmailPage() {
}
}, [member, onAction]);

const defaultSubscribedNewsletters = [...(member?.newsletters || [])];
const [subscribedNewsletters, setSubscribedNewsletters] = useState(defaultSubscribedNewsletters);
const {comments_enabled: commentsEnabled} = site;
const {enable_comment_notifications: enableCommentNotifications} = member || {};

useEffect(() => {
setSubscribedNewsletters(member?.newsletters || []);
}, [member?.newsletters]);
Expand Down

0 comments on commit ee7474d

Please sign in to comment.