Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Used unoptimized image when possible for dynamic images #10314

Merged
merged 2 commits into from
Jan 8, 2019
Merged

🐛 Used unoptimized image when possible for dynamic images #10314

merged 2 commits into from
Jan 8, 2019

Conversation

allouis
Copy link
Contributor

@allouis allouis commented Jan 2, 2019

closes #10283

Updated middleware for dynamic image sizes to attempt to read the unoptimized image first, taking into account the -n suffix for duplicate image names, by using a regex.

@allouis allouis changed the title 🐛 Used unoptimized image when possible for dynamic images [WIP] 🐛 Used unoptimized image when possible for dynamic images Jan 2, 2019
@allouis allouis changed the title [WIP] 🐛 Used unoptimized image when possible for dynamic images 🐛 Used unoptimized image when possible for dynamic images Jan 2, 2019
@kirrg001
Copy link
Contributor

kirrg001 commented Jan 4, 2019

Will review on Monday 🤪

@kevinansfield kevinansfield merged commit 935b0f6 into TryGhost:master Jan 8, 2019
@allouis allouis deleted the use-unoptimized-image-when-possible-for-dynamic-images branch January 8, 2019 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dynamic images should attempt to resize uncompressed "original" images
3 participants