🐛 Fixed "Cannot read property 'feature_image' of undefined" #10602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kirrg001
commented
Mar 12, 2019
| @@ -16,10 +16,12 @@ function getContextObject(data, context) { | |||
| // @TODO: meta layer is very broken, it's really hard to understand what it's doing | |||
| // The problem is that handlebars root object is structured differently. Sometimes the object is flat on data | |||
| // and sometimes the object is part of a key e.g. data.post. This needs to be prepared at the very first stage and not in each helper. | |||
| if (_.includes(context, 'page') || _.includes(context, 'amp') && data.post) { | |||
| if ((_.includes(context, 'page') || _.includes(context, 'amp')) && data.post) { | |||
There was a problem hiding this comment.
missing braaaces 🤬
no issue - refs https://forum.ghost.org/t/default-hbs-cannot-read-property-feature-image-of-undefined/6194 ``` routes: /: data: page.{slug} ```
kirrg001
commented
Mar 13, 2019
| chosenContext = data.post; | ||
| } else if (_.includes(context, 'post') && data.post) { | ||
| chosenContext = data.post; | ||
| } else if (_.includes(context, 'page') && data.page) { | ||
| chosenContext = data.page; |
There was a problem hiding this comment.
Added this extra case to ensure the data is returned for the case of using data: page.slug.
Dynamic routing has added a lot of extra cases for the meta layer, refs #10082.
kirrg001
commented
Mar 13, 2019
kirrg001
commented
Mar 13, 2019
| pages: [{redirect: true, slug: 'static-page-test'}] | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
The use case was not covered in dynamic routing regression test. Now it's there.
It errors on master
There was a problem hiding this comment.
Hm.. Tried it on master, didn't error 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs https://forum.ghost.org/t/default-hbs-cannot-read-property-feature-image-of-undefined/6194