Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Allowed fixing newsletter links #15672

Merged
merged 2 commits into from
Oct 21, 2022
Merged

✨ Allowed fixing newsletter links #15672

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4485bfd
✨ Allowed fixing newsletter links
rishabhgrg Oct 21, 2022
14dcb03
fixup! ✨ Allowed fixing newsletter links
rishabhgrg Oct 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 0 additions & 13 deletions ghost/admin/app/templates/settings/labs.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,19 +284,6 @@
</div>
</div>
</div>
<div class="gh-expandable-block">
<div class="gh-expandable-header">
<div>
<h4 class="gh-expandable-title">Fix newsletter links</h4>
<p class="gh-expandable-description">
Allow publishers to edit newsletter links after sending.
</p>
</div>
<div class="for-switch">
<GhFeatureFlag @flag="fixNewsletterLinks" />
</div>
</div>
</div>
</div>
</div>
{{/if}}
Expand Down
6 changes: 3 additions & 3 deletions ghost/core/core/shared/labs.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,8 @@ const GA_FEATURES = [
'freeTrial',
'compExpiring',
'searchHelper',
'emailAlerts'
'emailAlerts',
'fixNewsletterLinks'
];

// NOTE: this allowlist is meant to be used to filter out any unexpected
Expand All @@ -35,8 +36,7 @@ const ALPHA_FEATURES = [
'beforeAfterCard',
'lexicalEditor',
'exploreApp',
'audienceFeedback',
'fixNewsletterLinks'
'audienceFeedback'
];

module.exports.GA_KEYS = [...GA_FEATURES];
Expand Down
2 changes: 1 addition & 1 deletion ghost/core/test/e2e-api/admin/__snapshots__/settings.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -627,7 +627,7 @@ exports[`Settings API Edit Can edit a setting 2: [headers] 1`] = `
Object {
"access-control-allow-origin": "http://127.0.0.1:2369",
"cache-control": "no-cache, private, no-store, must-revalidate, max-stale=0, post-check=0, pre-check=0",
"content-length": "3450",
"content-length": "3478",
"content-type": "application/json; charset=utf-8",
"etag": StringMatching /\\(\\?:W\\\\/\\)\\?"\\(\\?:\\[ !#-\\\\x7E\\\\x80-\\\\xFF\\]\\*\\|\\\\r\\\\n\\[\\\\t \\]\\|\\\\\\\\\\.\\)\\*"/,
"vary": "Accept-Version, Origin, Accept-Encoding",
Expand Down