Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Improved sending email addresses for self-hosters #19617

Merged
merged 3 commits into from
Jan 30, 2024
Merged

✨ Improved sending email addresses for self-hosters #19617

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d7b4aed
✨ Improved sending email addresses for self-hosters
SimonBackx Jan 30, 2024
84d2638
Updated snapshots
SimonBackx Jan 30, 2024
339e241
Updated regression snapshots
SimonBackx Jan 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ghost/core/core/shared/labs.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,8 @@ const GA_FEATURES = [
'signupForm',
'recommendations',
'listUnsubscribeHeader',
'filterEmailDisabled'
'filterEmailDisabled',
'newEmailAddresses'
];

// NOTE: this allowlist is meant to be used to filter out any unexpected
Expand All @@ -47,7 +48,6 @@ const ALPHA_FEATURES = [
// 'adminXOffers',
'filterEmailDisabled',
'adminXDemo',
'newEmailAddresses',
'portalImprovements'
];

Expand Down
2 changes: 1 addition & 1 deletion ghost/core/test/e2e-api/admin/__snapshots__/settings.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1155,7 +1155,7 @@ exports[`Settings API Edit Can edit a setting 2: [headers] 1`] = `
Object {
"access-control-allow-origin": "http://127.0.0.1:2369",
"cache-control": "no-cache, private, no-store, must-revalidate, max-stale=0, post-check=0, pre-check=0",
"content-length": "4507",
"content-length": "4534",
"content-type": "application/json; charset=utf-8",
"content-version": StringMatching /v\\\\d\\+\\\\\\.\\\\d\\+/,
"etag": StringMatching /\\(\\?:W\\\\/\\)\\?"\\(\\?:\\[ !#-\\\\x7E\\\\x80-\\\\xFF\\]\\*\\|\\\\r\\\\n\\[\\\\t \\]\\|\\\\\\\\\\.\\)\\*"/,
Expand Down
6 changes: 4 additions & 2 deletions ghost/core/test/regression/api/admin/__snapshots__/authentication.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,8 +240,9 @@ [email protected] [[email protected]]"
exports[`Authentication API Blog setup complete setup 5: [metadata 1] 1`] = `
Object {
"encoding": "base64",
"from": "[email protected]",
"from": "\\"a test blog\\" <[email protected]>",
"generateTextFromHTML": true,
"replyTo": null,
"subject": "Your New Ghost Site",
"to": "[email protected]",
}
Expand Down Expand Up @@ -518,8 +519,9 @@ [email protected] [[email protected]]"
exports[`Authentication API Blog setup complete setup with default theme 5: [metadata 1] 1`] = `
Object {
"encoding": "base64",
"from": "[email protected]",
"from": "\\"a test blog\\" <[email protected]>",
"generateTextFromHTML": true,
"replyTo": null,
"subject": "Your New Ghost Site",
"to": "[email protected]",
}
Expand Down
1 change: 1 addition & 0 deletions ...core/test/unit/server/services/settings/__snapshots__/settings-bread-service.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,6 +192,7 @@ Object {
"forceTextContent": true,
"from": "\\"Ghost at 127.0.0.1\\" <[email protected]>",
"generateTextFromHTML": false,
"replyTo": null,
"subject": "Verify email address",
"to": "[email protected]",
}
Expand Down
Loading