Routable tags #5969
Merged
Routable tags #5969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinansfield
force-pushed
the
routable-tags
branch
9 times, most recently
from
876b0f0 to
9886754
Compare
kevinansfield
force-pushed
the
routable-tags
branch
2 times, most recently
from
7f92457 to
e374ea7
Compare
kevinansfield
force-pushed
the
routable-tags
branch
from
e374ea7 to
ca7ebdf
Compare
kevinansfield
force-pushed
the
routable-tags
branch
4 times, most recently
from
f38f5c6 to
23e8ad9
Compare
|
😞 Realised this needs some more work for mobile. Opening a separate PR for that as this is already huge. |
|
Playing around with this I've spotted a couple of things:
|
D'oh that's come back? I was sure that had been nailed in d49991f 😞
Good catch! I need to toggle the keymaster scope somewhere to prevent that... |
no issue - adds `shouldBackgroundReloadRecord` override so that we keep the current behaviour (never background reload unless instigated manually) when we upgrade to Ember Data 2.0 which will always background-reload by default
no issue - delete old/unused CSS that was used for an old tag component
kevinansfield
force-pushed
the
routable-tags
branch
from
23e8ad9 to
061d68e
Compare
kevinansfield
force-pushed
the
routable-tags
branch
from
061d68e to
8fc7d39
Compare
|
@ErisDS both issues should be fixed now. |
kevinansfield
force-pushed
the
routable-tags
branch
from
8fc7d39 to
f6243bd
Compare
refs TryGhost#5845 - Updates tag settings screen to match content screen behaviour. Each now tag has it's own route that is link-able from other areas of the app - Updates a number of places where jQuery event handler code was not wrapped in Ember's run loop
kevinansfield
force-pushed
the
routable-tags
branch
from
f6243bd to
bc346d2
Compare
kevinansfield
added a commit
to kevinansfield/Ghost
that referenced
this pull request
Nov 2, 2015
refs TryGhost#5845, TryGhost#5969 - when on mobile devices tag management UI will only display a list and when a tag is accessed the tag settings form will slide in from the right - tag settings form header has a 'back' button when on mobile to go back to tags list - switching from mobile to standard modes will auto load the first tag as per standard tags screen on desktop - if no tags are present then the blank-slate template will be shown when on mobile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #5845
Notes:
The tag creation process did appear a little strange when converting the existing functionality. A new tag is created/saved as soon as a field loses focus and the overall tag is in a valid state - this initially caused problems as the tag now has it's own route and appears in the list but you were left on the /new route and the newly added tag was not selected meaning to create another new tag you had to select a different tag first. To work around this I automatically perform a "replace" transition as soon as a tag is saved - it fixes the UI inconsistencies but I wonder if there is a better way to handle saving/creation in general, especially if you want to abort creating a new tag?
TODO:
Ember.run.bindwhere values are dynamic